From: Christoph Hellwig <hch@infradead.org>
To: Jiri Slaby <jirislaby@gmail.com>
Cc: Pavel Emelyanov <xemul@openvz.org>,
"David S. Miller" <davem@davemloft.net>,
netdev@vger.kernel.org
Subject: Re: sock_valbool_flag is required by VMware
Date: Sun, 2 Dec 2007 13:58:51 +0000 [thread overview]
Message-ID: <20071202135851.GA1164@infradead.org> (raw)
In-Reply-To: <47508616.4030705@gmail.com>
On Fri, Nov 30, 2007 at 10:52:22PM +0100, Jiri Slaby wrote:
> Hi,
>
> this commit:
> [NET]: Move sock_valbool_flag to socket.c
>
> The sock_valbool_flag() helper is used in setsockopt to
> set or reset some flag on the sock. This helper is required
> in the net/socket.c only, so move it there.
>
> Besides, patch two places in sys_setsockopt() that repeat
> this helper functionality manually.
>
> Since this is not a bugfix, but a trivial cleanup, I
> prepared this patch against net-2.6.25, but it also
> applies (with a single offset) to the latest net-2.6.
>
> breaks vmware module compilation, since it uses sock_valbool_flag(). Is this
> their business (and they should use sock_set_flag/sock_reset_flag) or should
> this be reverted?
It's their business, they should never have used it.
prev parent reply other threads:[~2007-12-02 13:58 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-11-30 21:52 sock_valbool_flag is required by VMware Jiri Slaby
2007-12-02 13:58 ` Christoph Hellwig [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20071202135851.GA1164@infradead.org \
--to=hch@infradead.org \
--cc=davem@davemloft.net \
--cc=jirislaby@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=xemul@openvz.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).