From: Thierry Reding <thierry.reding@avionic-design.de>
To: Jeff Garzik <jeff@garzik.org>
Cc: netdev@vger.kernel.org, David Miller <davem@davemloft.net>,
Andrew Morton <akpm@linux-foundation.org>
Subject: [PATCH][RESEND] PHY: Add the phy_device_release device method.
Date: Mon, 3 Dec 2007 09:35:11 +0100 [thread overview]
Message-ID: <20071203083511.GA9396@avionic-tr-basi.adnet.avionic-design.de> (raw)
In-Reply-To: <4751D9F3.5090502@garzik.org>
[-- Attachment #1: Type: text/plain, Size: 1639 bytes --]
In cases where more than a single PHY is found on the MDIO bus, the kernel
will print a warning that this method is missing for each PHY device that
is not attached to a networking device.
Signed-off-by: Thierry Reding <thierry.reding@avionic-design.de>
---
drivers/net/phy/mdio_bus.c | 19 ++++++++++++++++++-
1 files changed, 18 insertions(+), 1 deletions(-)
diff --git a/drivers/net/phy/mdio_bus.c b/drivers/net/phy/mdio_bus.c
index fc2f0e6..cb7fb47 100644
--- a/drivers/net/phy/mdio_bus.c
+++ b/drivers/net/phy/mdio_bus.c
@@ -36,6 +36,23 @@
#include <asm/uaccess.h>
/**
+ * phy_device_release - free a phy_device structure when all users of it are
+ * finished.
+ *
+ * @dev: device that's been disconnected
+ *
+ * Will be called only by the device core when all users of this phy_device
+ * are done.
+ */
+static void phy_device_release(struct device *dev)
+{
+ struct phy_device *phy;
+
+ phy = to_phy_device(dev);
+ kfree(phy);
+}
+
+/**
* mdiobus_register - bring up all the PHYs on a given bus and attach them to bus
* @bus: target mii_bus
*
@@ -83,6 +100,7 @@ int mdiobus_register(struct mii_bus *bus)
if (phydev) {
phydev->irq = bus->irq[i];
+ phydev->dev.release = phy_device_release;
phydev->dev.parent = bus->dev;
phydev->dev.bus = &mdio_bus_type;
snprintf(phydev->dev.bus_id, BUS_ID_SIZE, PHY_ID_FMT, bus->id, i);
@@ -112,7 +130,6 @@ void mdiobus_unregister(struct mii_bus *bus)
for (i = 0; i < PHY_MAX_ADDR; i++) {
if (bus->phy_map[i]) {
device_unregister(&bus->phy_map[i]->dev);
- kfree(bus->phy_map[i]);
}
}
}
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 189 bytes --]
next prev parent reply other threads:[~2007-12-03 8:35 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20071119.214215.207388094.davem@davemloft.net>
2007-12-01 22:02 ` Fw: [PATCH] Add the phy_device_release device method Jeff Garzik
2007-12-03 8:35 ` Thierry Reding [this message]
2007-12-04 5:44 ` [PATCH][RESEND] PHY: " Andrew Morton
2007-12-04 7:38 ` Thierry Reding
2007-12-04 13:17 ` Anton Vorontsov
2007-12-04 20:06 ` Jeff Garzik
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20071203083511.GA9396@avionic-tr-basi.adnet.avionic-design.de \
--to=thierry.reding@avionic-design.de \
--cc=akpm@linux-foundation.org \
--cc=davem@davemloft.net \
--cc=jeff@garzik.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).