From: Samuel Ortiz <samuel@sortiz.org>
To: Herbert Xu <herbert@gondor.apana.org.au>,
netdev@vger.kernel.org, irda-users@lists.sourceforge.net
Cc: "David S. Miller" <davem@davemloft.net>,
Hinko Kocevar <hinko.kocevar@cetrtapot.si>
Subject: [PATCH 2/5] [IrDA] mcs7780 needs to free allocated rx buffer
Date: Mon, 03 Dec 2007 10:28:33 +0100 [thread overview]
Message-ID: <20071203093053.368759253@sortiz.org> (raw)
In-Reply-To: 20071203092831.724254969@sortiz.org
[-- Attachment #1: mcs7780-free-rx_buff.diff --]
[-- Type: text/plain, Size: 802 bytes --]
While testing the mcs7780 based IrDA USB dongle I've stumbled upon
memory leak in mcs_net_close(). Patch below fixes it.
Signed-off-by: Hinko Kocevar <hinko.kocevar@cetrtapot.si>
Signed-off-by: Samuel Ortiz <samuel@sortiz.org>
---
drivers/net/irda/mcs7780.c | 2 ++
1 file changed, 2 insertions(+)
Index: net-2.6/drivers/net/irda/mcs7780.c
===================================================================
--- net-2.6.orig/drivers/net/irda/mcs7780.c 2007-11-25 05:53:43.000000000 +0100
+++ net-2.6/drivers/net/irda/mcs7780.c 2007-11-25 07:12:11.000000000 +0100
@@ -677,6 +677,8 @@
/* Stop transmit processing */
netif_stop_queue(netdev);
+ kfree_skb(mcs->rx_buff.skb);
+
/* kill and free the receive and transmit URBs */
usb_kill_urb(mcs->rx_urb);
usb_free_urb(mcs->rx_urb);
--
next prev parent reply other threads:[~2007-12-03 1:29 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-12-03 9:28 [PATCH 0/5] [IrDA] IrDA updates for net-2.6 Samuel Ortiz
2007-12-03 6:57 ` Herbert Xu
2007-12-03 9:28 ` [PATCH 1/5] [IrDA] Race between open and disconnect in irda-usb Samuel Ortiz
2007-12-03 9:28 ` Samuel Ortiz [this message]
2007-12-03 9:28 ` [PATCH 3/5] [IrDA] irlmp_unregister_link needs to free lsaps Samuel Ortiz
2007-12-03 9:28 ` [PATCH 4/5] [IrDA] stir4200 fixes Samuel Ortiz
2007-12-03 9:28 ` [PATCH 5/5] [IrDA] irda parameters warning fixes Samuel Ortiz
-- strict thread matches above, loose matches on Subject: below --
2007-12-16 23:46 [PATCH 0/5] [IrDA] IrDA net-2.6 fixes Samuel Ortiz
2007-12-16 23:46 ` [PATCH 2/5] [IrDA] mcs7780 needs to free allocated rx buffer Samuel Ortiz
[not found] ` <20071216234933.121032143-jcdQHdrhKHMdnm+yROfE0A@public.gmane.org>
2007-12-16 22:08 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20071203093053.368759253@sortiz.org \
--to=samuel@sortiz.org \
--cc=davem@davemloft.net \
--cc=herbert@gondor.apana.org.au \
--cc=hinko.kocevar@cetrtapot.si \
--cc=irda-users@lists.sourceforge.net \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).