From: Samuel Ortiz <samuel@sortiz.org>
To: Herbert Xu <herbert@gondor.apana.org.au>,
netdev@vger.kernel.org, irda-users@lists.sourceforge.net
Cc: "David S. Miller" <davem@davemloft.net>,
Richard Knutsson <ricknu-0@student.ltu.se>,
Andrew Morton <akpm@linux-foundation.org>
Subject: [PATCH 5/5] [IrDA] irda parameters warning fixes.
Date: Mon, 03 Dec 2007 10:28:36 +0100 [thread overview]
Message-ID: <20071203093053.944365836@sortiz.org> (raw)
In-Reply-To: 20071203092831.724254969@sortiz.org
[-- Attachment #1: irda_parameters.patch --]
[-- Type: text/plain, Size: 1549 bytes --]
This patch fixes:
CHECK /home/kernel/src/net/irda/parameters.c
/home/kernel/src/net/irda/parameters.c:466:2: warning: Using plain integer as NULL pointer
/home/kernel/src/net/irda/parameters.c:520:2: warning: Using plain integer as NULL pointer
/home/kernel/src/net/irda/parameters.c:573:2: warning: Using plain integer as NULL pointer
Signed-off-by: Richard Knutsson <ricknu-0@student.ltu.se>
Signed-off-by: Samuel Ortiz <samuel@sortiz.org>
Cc: Andrew Morton <akpm@linux-foundation.org>
---
net/irda/parameters.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
Index: net-2.6/net/irda/parameters.c
===================================================================
--- net-2.6.orig/net/irda/parameters.c 2007-11-25 05:54:02.000000000 +0100
+++ net-2.6/net/irda/parameters.c 2007-11-26 10:20:38.000000000 +0100
@@ -463,7 +463,7 @@
int n = 0;
IRDA_ASSERT(buf != NULL, return ret;);
- IRDA_ASSERT(info != 0, return ret;);
+ IRDA_ASSERT(info != NULL, return ret;);
pi_minor = pi & info->pi_mask;
pi_major = pi >> info->pi_major_offset;
@@ -517,7 +517,7 @@
int n = 0;
IRDA_ASSERT(buf != NULL, return ret;);
- IRDA_ASSERT(info != 0, return ret;);
+ IRDA_ASSERT(info != NULL, return ret;);
pi_minor = buf[n] & info->pi_mask;
pi_major = buf[n] >> info->pi_major_offset;
@@ -570,7 +570,7 @@
int n = 0;
IRDA_ASSERT(buf != NULL, return ret;);
- IRDA_ASSERT(info != 0, return ret;);
+ IRDA_ASSERT(info != NULL, return ret;);
/*
* Parse all parameters. Each parameter must be at least two bytes
--
next prev parent reply other threads:[~2007-12-03 1:29 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-12-03 9:28 [PATCH 0/5] [IrDA] IrDA updates for net-2.6 Samuel Ortiz
2007-12-03 6:57 ` Herbert Xu
2007-12-03 9:28 ` [PATCH 1/5] [IrDA] Race between open and disconnect in irda-usb Samuel Ortiz
2007-12-03 9:28 ` [PATCH 2/5] [IrDA] mcs7780 needs to free allocated rx buffer Samuel Ortiz
2007-12-03 9:28 ` [PATCH 3/5] [IrDA] irlmp_unregister_link needs to free lsaps Samuel Ortiz
2007-12-03 9:28 ` [PATCH 4/5] [IrDA] stir4200 fixes Samuel Ortiz
2007-12-03 9:28 ` Samuel Ortiz [this message]
-- strict thread matches above, loose matches on Subject: below --
2007-12-16 23:46 [PATCH 0/5] [IrDA] IrDA net-2.6 fixes Samuel Ortiz
2007-12-16 23:46 ` [PATCH 5/5] [IrDA] irda parameters warning fixes Samuel Ortiz
[not found] ` <20071216234933.666730217-jcdQHdrhKHMdnm+yROfE0A@public.gmane.org>
2007-12-16 22:11 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20071203093053.944365836@sortiz.org \
--to=samuel@sortiz.org \
--cc=akpm@linux-foundation.org \
--cc=davem@davemloft.net \
--cc=herbert@gondor.apana.org.au \
--cc=irda-users@lists.sourceforge.net \
--cc=netdev@vger.kernel.org \
--cc=ricknu-0@student.ltu.se \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).