From: David Miller <davem@davemloft.net>
To: horms@verge.net.au
Cc: xemul@openvz.org, herbert@gondor.apana.org.au,
netdev@vger.kernel.org, devel@openvz.org, wensong@linux-vs.org,
ja@ssi.bg
Subject: Re: [PATCH][IPVS] Fix sched registration race when checking for name collision
Date: Tue, 04 Dec 2007 00:45:25 -0800 (PST) [thread overview]
Message-ID: <20071204.004525.246971804.davem@davemloft.net> (raw)
In-Reply-To: <20071204014142.GC28582@verge.net.au>
From: Simon Horman <horms@verge.net.au>
Date: Tue, 4 Dec 2007 10:41:43 +0900
> On Mon, Dec 03, 2007 at 01:10:57PM +0300, Pavel Emelyanov wrote:
> > The register_ip_vs_scheduler() checks for the scheduler with the
> > same name under the read-locked __ip_vs_sched_lock, then drops,
> > takes it for writing and puts the scheduler in list.
> >
> > This is racy, since we can have a race window between the lock
> > being re-locked for writing.
> >
> > The fix is to search the scheduler with the given name right under
> > the write-locked __ip_vs_sched_lock.
>
> This looks correct to me.
>
> > Signed-off-by: Pavel Emelyanov <xemul@openvz.org>
>
> Acked-by: Simon Horman <horms@verge.net.au>
Also applied, thanks a lot.
prev parent reply other threads:[~2007-12-04 8:45 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-12-03 10:10 [PATCH][IPVS] Fix sched registration race when checking for name collision Pavel Emelyanov
2007-12-04 1:41 ` Simon Horman
2007-12-04 8:45 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20071204.004525.246971804.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=devel@openvz.org \
--cc=herbert@gondor.apana.org.au \
--cc=horms@verge.net.au \
--cc=ja@ssi.bg \
--cc=netdev@vger.kernel.org \
--cc=wensong@linux-vs.org \
--cc=xemul@openvz.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).