From: David Miller <davem@davemloft.net>
To: herbert@gondor.apana.org.au
Cc: netdev@vger.kernel.org
Subject: Re: [PATCH 3/3] [UDP]: Only increment counter on first peek/recv
Date: Wed, 05 Dec 2007 01:54:09 -0800 (PST) [thread overview]
Message-ID: <20071205.015409.116581624.davem@davemloft.net> (raw)
In-Reply-To: <20071204130310.GB3098@gondor.apana.org.au>
From: Herbert Xu <herbert@gondor.apana.org.au>
Date: Wed, 5 Dec 2007 00:03:10 +1100
> [UDP]: Only increment counter on first peek/recv
>
> The previous move of the the UDP inDatagrams counter caused each
> peek of the same packet to be counted separately. This may be
> undesirable.
>
> This patch fixes this by adding a bit to sk_buff to record whether
> this packet has already been seen through skb_recv_datagram. We
> then only increment the counter when the packet is seen for the
> first time.
>
> The only dodgy part is the fact that skb_recv_datagram doesn't have
> a good way of returning this new bit of information. So I've added
> a new function __skb_recv_datagram that does return this and made
> skb_recv_datagram a wrapper around it.
>
> The plan is to eventually replace all uses of skb_recv_datagram with
> this new function at which time it can be renamed its proper name.
>
> Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>
Applied, thanks for fixing all of this Herbert.
next prev parent reply other threads:[~2007-12-05 9:54 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-12-04 12:58 [PATCH 1/3] [UDP]: Avoid repeated counting of checksum errors due to peeking Herbert Xu
2007-12-04 13:01 ` [PATCH 2/3] [UDP]: Restore missing inDatagrams increments Herbert Xu
2007-12-04 13:03 ` [PATCH 3/3] [UDP]: Only increment counter on first peek/recv Herbert Xu
2007-12-05 9:54 ` David Miller [this message]
2007-12-05 1:02 ` [PATCH 2/3] [UDP]: Restore missing inDatagrams increments Herbert Xu
2007-12-05 1:42 ` Wang Chen
2007-12-05 2:15 ` Herbert Xu
2007-12-05 8:39 ` Wang Chen
2007-12-05 9:02 ` Herbert Xu
2007-12-05 9:04 ` Wang Chen
2007-12-05 9:10 ` Herbert Xu
2007-12-05 9:20 ` Wang Chen
2007-12-05 9:26 ` Herbert Xu
2007-12-05 9:36 ` Eric Dumazet
2007-12-05 9:51 ` Herbert Xu
2007-12-05 10:02 ` David Miller
2007-12-05 10:04 ` Herbert Xu
2007-12-05 10:08 ` David Miller
2007-12-05 9:53 ` David Miller
2007-12-05 9:54 ` Herbert Xu
2007-12-05 9:52 ` [PATCH 1/3] [UDP]: Avoid repeated counting of checksum errors due to peeking David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20071205.015409.116581624.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=herbert@gondor.apana.org.au \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).