From: David Miller <davem@davemloft.net>
To: ilpo.jarvinen@helsinki.fi
Cc: netdev@vger.kernel.org
Subject: Re: [PATCH 3/3] [TCP]: NAGLE_PUSH seems to be a wrong way around
Date: Wed, 05 Dec 2007 03:33:48 -0800 (PST) [thread overview]
Message-ID: <20071205.033348.155990962.davem@davemloft.net> (raw)
In-Reply-To: <Pine.LNX.4.64.0712051242310.18529@kivilampi-30.cs.helsinki.fi>
From: "Ilpo_Järvinen" <ilpo.jarvinen@helsinki.fi>
Date: Wed, 5 Dec 2007 13:18:14 +0200 (EET)
> ...If I understood the very old history correctly, this bug was introduced
> in 2.4.0-test12 which inverted !tail incorrectly to nonagle==1.
>
> You can check include/net/tcp.h diffs from this commit:
> http://www.linux-mips.org/git?p=linux.git;a=commitdiff;h=c9c06167e7933d93a6e396174c68abf242294abb
>
> ...Though it's very large one. So I included only the relevant portion
> here below.
Thanks for the info, indeed it seems it has been broken this
way all this time.
next prev parent reply other threads:[~2007-12-05 11:33 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-12-04 16:48 [PATCH net-2.6 0/3]: Three TCP fixes Ilpo Järvinen
2007-12-04 16:48 ` [PATCH 1/3] [TCP] FRTO: Use of existing funcs make code more obvious & robust Ilpo Järvinen
2007-12-04 16:48 ` [PATCH 2/3] [TCP]: Move prior_in_flight collect to more robust place Ilpo Järvinen
2007-12-04 16:48 ` [PATCH 3/3] [TCP]: NAGLE_PUSH seems to be a wrong way around Ilpo Järvinen
2007-12-05 10:26 ` David Miller
2007-12-05 11:18 ` Ilpo Järvinen
2007-12-05 11:33 ` David Miller [this message]
2007-12-05 10:21 ` [PATCH 2/3] [TCP]: Move prior_in_flight collect to more robust place David Miller
2007-12-05 10:21 ` [PATCH 1/3] [TCP] FRTO: Use of existing funcs make code more obvious & robust David Miller
2007-12-04 18:42 ` [PATCH net-2.6 0/3]: Three TCP fixes John Heffner
2007-12-04 21:10 ` Ilpo Järvinen
2007-12-04 21:17 ` John Heffner
2007-12-04 21:26 ` Ilpo Järvinen
2007-12-05 11:17 ` Alexey Kuznetsov
2007-12-05 2:13 ` Matt Mathis
2007-12-05 10:30 ` David Miller
2007-12-05 11:30 ` Ilpo Järvinen
2007-12-06 4:56 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20071205.033348.155990962.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=ilpo.jarvinen@helsinki.fi \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).