From: KOVACS Krisztian <hidden@sch.bme.hu>
To: Balazs Scheidler <bazsi@balabit.hu>
Cc: panther@balabit.hu, netdev@vger.kernel.org
Subject: Re: cassini driver skb->truesize bug
Date: Wed, 5 Dec 2007 18:30:57 +0100 [thread overview]
Message-ID: <20071205173056.GA19264@sch.bme.hu> (raw)
In-Reply-To: <1196850226.9713.33.camel@bzorp.balabit>
Hi,
On Wed, Dec 05, 2007 at 11:23:46AM +0100, Balazs Scheidler wrote:
> Some more investigation revealed that the cassini driver leaks the data
> portion of all RXed packets, this makes the driver completely unusable.
>
> We've tested the following combinations:
> * 2.6.17 (patched, but no cassini related patches)
> * 2.6.22 Ubuntu Gutsy.
>
> It still worked in 2.6.12 where we originally backported the driver from
> 2.6.14.
>
> The sk_buff count in slabinfo stays normal, so the skbs are properly
> freed. I'm suspicious about all this cas_page_t wrappers.
Commit fa4f0774d7c6cccb4d1fda76b91dd8eddcb2dd6a?
I don't really see how the buffer count for a page used as a fragment gets
decreased when the skb is freed.
--
KOVACS Krisztian
prev parent reply other threads:[~2007-12-05 18:06 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-12-04 14:19 cassini driver skb->truesize bug Laszlo Attila Toth
2007-12-05 10:23 ` Balazs Scheidler
2007-12-05 10:41 ` David Miller
2007-12-05 17:30 ` KOVACS Krisztian [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20071205173056.GA19264@sch.bme.hu \
--to=hidden@sch.bme.hu \
--cc=bazsi@balabit.hu \
--cc=netdev@vger.kernel.org \
--cc=panther@balabit.hu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).