From: Francois Romieu <romieu@fr.zoreil.com>
To: Joe Perches <joe@perches.com>
Cc: jeff@garzik.org, Pekka Enberg <penberg@cs.helsinki.fi>,
Sorbica Shieh <sorbica@icplus.com.tw>,
Jesse Huang <jesse@icplus.com.tw>,
Andrew Morton <akpm@linux-foundation.org>,
netdev@vger.kernel.org
Subject: Re: Pull request for 'ipg' branch
Date: Wed, 5 Dec 2007 22:51:57 +0100 [thread overview]
Message-ID: <20071205215157.GA3665@electric-eye.fr.zoreil.com> (raw)
In-Reply-To: <1196806495.10819.16.camel@localhost>
Joe Perches <joe@perches.com> :
[...]
> > - if ((sp->LED_Mode & 0x01) == 1)
> > + if ((sp->led_mode & 0x01) == 1)
>
> I think the use of hex and decimal constants is odd.
> I think "if (sp->led_mode & 0x01)" is better.
Yes, the whole context of this code in the driver is a bit special.
[...]
> > /* Assign IPG_APPEND_FCS_ON_TX > 0 for auto FCS append on TX. */
> > -#define IPG_APPEND_FCS_ON_TX TRUE
> > +#define IPG_APPEND_FCS_ON_TX 1
>
> Why not true and false?
No objection. Both can be used.
[...]
> > @@ -753,8 +732,7 @@ enum ipg_regs {
> > * Miscellaneous macros.
> > */
> >
> > -/* Marco for printing debug statements.
> > -# define IPG_DDEBUG_MSG(args...) printk(KERN_DEBUG "IPG: " ## args) */
> > +/* Marco for printing debug statements. */
>
> Macros
I actively ignored it. It was not easy. :o)
--
Ueimor
next prev parent reply other threads:[~2007-12-05 21:58 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-12-04 21:45 Pull request for 'ipg' branch Francois Romieu
2007-12-04 22:14 ` Joe Perches
2007-12-05 21:51 ` Francois Romieu [this message]
2007-12-17 23:18 ` Jeff Garzik
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20071205215157.GA3665@electric-eye.fr.zoreil.com \
--to=romieu@fr.zoreil.com \
--cc=akpm@linux-foundation.org \
--cc=jeff@garzik.org \
--cc=jesse@icplus.com.tw \
--cc=joe@perches.com \
--cc=netdev@vger.kernel.org \
--cc=penberg@cs.helsinki.fi \
--cc=sorbica@icplus.com.tw \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).