From: Jarek Poplawski <jarkao2@o2.pl>
To: Mitsuru Chinen <mitch@linux.vnet.ibm.com>
Cc: netdev@vger.kernel.org, David Miller <davem@davemloft.net>,
Rami Rosen <roszenrami@gmail.com>
Subject: Re: [PATCH] [IPv4] Reply net unreachable ICMP message
Date: Thu, 6 Dec 2007 09:47:33 +0100 [thread overview]
Message-ID: <20071206084733.GB2164@ff.dom.local> (raw)
In-Reply-To: <20071206171421.1495c019.mitch@linux.vnet.ibm.com>
On 06-12-2007 09:14, Mitsuru Chinen wrote:
> On Thu, 6 Dec 2007 08:49:47 +0100
> Jarek Poplawski <jarkao2@o2.pl> wrote:
>
>> On 06-12-2007 07:31, Mitsuru Chinen wrote:
>>> IPv4 stack doesn't reply any ICMP destination unreachable message
>>> with net unreachable code when IP detagrams are being discarded
>>> because of no route could be found in the forwarding path.
>>> Incidentally, IPv6 stack replies such ICMPv6 message in the similar
>>> situation.
...
>> This patch seems to be wrong. It overrides err codes from
>> fib_lookup, where such decisions should be made.
>
> fib_lookup() replies -ESRCH in this situation.
> It is necessary to override the variable by the suitable error
> number like the code under e_hostunreach label.
Probably I miss something, but I can't see how can you be sure it's
only -ESRCH possible here? Isn't opt->action() in fib_rules_lookup()
supposed to return this -ENETUNREACH when needed?
Jarek P.
next prev parent reply other threads:[~2007-12-06 8:42 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-12-06 6:31 [PATCH] [IPv4] Reply net unreachable ICMP message Mitsuru Chinen
2007-12-06 6:33 ` David Miller
2007-12-06 7:49 ` Jarek Poplawski
2007-12-06 8:12 ` Rami Rosen
2007-12-06 8:14 ` Mitsuru Chinen
2007-12-06 8:47 ` Jarek Poplawski [this message]
2007-12-07 4:23 ` Mitsuru Chinen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20071206084733.GB2164@ff.dom.local \
--to=jarkao2@o2.pl \
--cc=davem@davemloft.net \
--cc=jarkao2@gmail.com \
--cc=mitch@linux.vnet.ibm.com \
--cc=netdev@vger.kernel.org \
--cc=roszenrami@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).