From: Andy Gospodarek <andy@greyhouse.net>
To: netdev@vger.kernel.org
Cc: ram.vepa@neterion.com, santosh.rastapur@neterion.com,
sivakumar.subramani@neterion.com, sreenivasa.honnur@neterion.com
Subject: [PATCH] s2io: fix inconsistent hardware VLAN tagging during driver init
Date: Thu, 6 Dec 2007 14:57:13 -0500 [thread overview]
Message-ID: <20071206195713.GA25879@gospo.usersys.redhat.com> (raw)
The s2io driver keeps a local variable around (vlan_strip_flag) to keep
track of the current state of the hardware and whether or not it will
strip VLAN tags on incoming packets. It seems as though the hardware
default is to strip them, but that variable is not set correctly during
initialization if the default setup is used. This check ensures
vlan_strip_flag and the hardware setting are in sync.
These variables were introduced by this patch:
commit 926930b202d56c3dfb6aea0a0c6bfba2b87a8c03
Author: Sivakumar Subramani <Sivakumar.Subramani@neterion.com>
Date: Sat Feb 24 01:59:39 2007 -0500
so this problem hasn't been around forever.
Recent patches from Ramkrishna Vepa <ram.vepa@neterion.com> removed this
variable and would have worked around the problem, but they were not
accepted.
Signed-off-by: Andy Gospodarek <andy@greyhouse.net>
---
s2io.c | 5 +++++
1 files changed, 5 insertions(+)
diff --git a/drivers/net/s2io.c b/drivers/net/s2io.c
index 8b9f0ea..08c08de 100644
--- a/drivers/net/s2io.c
+++ b/drivers/net/s2io.c
@@ -2151,6 +2151,11 @@ static int start_nic(struct s2io_nic *nic)
val64 &= ~RX_PA_CFG_STRIP_VLAN_TAG;
writeq(val64, &bar0->rx_pa_cfg);
vlan_strip_flag = 0;
+ } else {
+ val64 = readq(&bar0->rx_pa_cfg);
+ val64 |= RX_PA_CFG_STRIP_VLAN_TAG;
+ writeq(val64, &bar0->rx_pa_cfg);
+ vlan_strip_flag = 1;
}
/*
next reply other threads:[~2007-12-06 19:57 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-12-06 19:57 Andy Gospodarek [this message]
2007-12-07 21:02 ` [PATCH] s2io: fix inconsistent hardware VLAN tagging during driver init Ramkrishna Vepa
2007-12-07 21:17 ` Jeff Garzik
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20071206195713.GA25879@gospo.usersys.redhat.com \
--to=andy@greyhouse.net \
--cc=netdev@vger.kernel.org \
--cc=ram.vepa@neterion.com \
--cc=santosh.rastapur@neterion.com \
--cc=sivakumar.subramani@neterion.com \
--cc=sreenivasa.honnur@neterion.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).