Netdev List
 help / color / mirror / Atom feed
From: David Miller <davem@davemloft.net>
To: jeff@pobox.com
Cc: netdev@vger.kernel.org
Subject: 2.6.24 net driver mis-patch
Date: Fri, 07 Dec 2007 23:43:43 -0800 (PST)	[thread overview]
Message-ID: <20071207.234343.223864492.davem@davemloft.net> (raw)


Jeff, this belonged in netdev-2.6, Linus's tree doesn't have the BNX2X
driver yet, your 2.6.25 bound tree does.

As a result you added the ZLIB_INFLATE dependency to the TEHUTI driver
in 2.6.24 instead of BNX2X where it belongs, please fix this, thanks
:-)

commit 70eba18b5664f90d7620905e005b89388e5fd94b
Author: Eliezer Tamir <eliezert@broadcom.com>
Date:   Wed Dec 5 16:12:39 2007 +0200

    make bnx2x select ZLIB_INFLATE
    
    The bnx2x module depends on the zlib_inflate functions.  The
    build will fail if ZLIB_INFLATE has not been selected manually
    or by building another module that automatically selects it.
    
    Modify BNX2X config option to 'select ZLIB_INFLATE' like BNX2
    and others.  This seems to fix it.
    
    Signed-off-by:  Lee Schermerhorn <lee.schermerhorn@hp.com>
    Acked-by: Eliezer Tamir <eliezert@broadcom.com>
    Signed-off-by: Jeff Garzik <jeff@garzik.org>

diff --git a/drivers/net/Kconfig b/drivers/net/Kconfig
index d9107e5..6cde4ed 100644
--- a/drivers/net/Kconfig
+++ b/drivers/net/Kconfig
@@ -2588,6 +2588,7 @@ config MLX4_DEBUG
 config TEHUTI
 	tristate "Tehuti Networks 10G Ethernet"
 	depends on PCI
+	select ZLIB_INFLATE
 	help
 	  Tehuti Networks 10G Ethernet NIC
 

                 reply	other threads:[~2007-12-08  7:43 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20071207.234343.223864492.davem@davemloft.net \
    --to=davem@davemloft.net \
    --cc=jeff@pobox.com \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox