From: Paul Moore <paul.moore@hp.com>
To: Eric Paris <eparis@redhat.com>
Cc: netdev@vger.kernel.org, linux-audit@redhat.com, selinux@tycho.nsa.gov
Subject: Re: [PATCH] XFRM: assorted IPsec fixups
Date: Fri, 7 Dec 2007 15:45:41 -0500 [thread overview]
Message-ID: <200712071545.45411.paul.moore@hp.com> (raw)
In-Reply-To: <1197059769.3183.16.camel@dhcp231-215.rdu.redhat.com>
On Friday 07 December 2007 3:36:08 pm Eric Paris wrote:
> On Fri, 2007-12-07 at 12:11 -0500, Paul Moore wrote:
> > This patch fixes a number of small but potentially troublesome things in
> > the XFRM/IPsec code:
> >
> > * Use the 'audit_enabled' variable already in include/linux/audit.h
> > Removed the need for extern declarations local to each XFRM audit
> > fuction
{snip}
> although it does make me wonder why audit_log_start doesn't just check
> audit_enabled itself....
/me shrugs ... I have no idea, I've just always followed the lead of what was
already written, but now that you mention it - it doesn't make much sense. I
suppose at some point we can go through and change all the 'audit_enabled'
users, but I wonder if there is some point (?performance?) to having the
callers check?
--
paul moore
linux security @ hp
next prev parent reply other threads:[~2007-12-07 20:45 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-12-07 17:11 [PATCH] XFRM: assorted IPsec fixups Paul Moore
2007-12-07 20:36 ` Eric Paris
2007-12-07 20:45 ` Paul Moore [this message]
2007-12-11 10:22 ` David Miller
2007-12-11 14:05 ` Paul Moore
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200712071545.45411.paul.moore@hp.com \
--to=paul.moore@hp.com \
--cc=eparis@redhat.com \
--cc=linux-audit@redhat.com \
--cc=netdev@vger.kernel.org \
--cc=selinux@tycho.nsa.gov \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).