From: David Miller <davem@davemloft.net>
To: rdreier@cisco.com
Cc: netdev@vger.kernel.org, jeff@garzik.org,
torvalds@linux-foundation.org, eliezert@broadcom.com,
lee.schermerhorn@hp.com
Subject: Re: Bogus commit 70eba18b ("make bnx2x select ZLIB_INFLATE")?
Date: Sun, 09 Dec 2007 00:52:45 -0800 (PST) [thread overview]
Message-ID: <20071209.005245.241039796.davem@davemloft.net> (raw)
In-Reply-To: <adasl2ca7md.fsf@cisco.com>
From: Roland Dreier <rdreier@cisco.com>
Date: Sat, 08 Dec 2007 19:07:22 -0800
> Commit 70eba18b ("make bnx2x select ZLIB_INFLATE") in Linus's tree
> seems bogus. As far as I can tell, bnx2x is not upstream yet, and the
> commit in question actually adds "select ZLIB_INFLATE" to the TEHUTI
> config, since there is no BNX2X config option (and also I don't see
> any reference to zlib in any tehuti files).
>
> I assume this is some sort of merge problem that got added to the
> wrong tree and should be reverted upstream.
I already pointed this out to Jeff, here:
http://marc.info/?l=linux-netdev&m=119709982603567&w=2
Indeed, it needs to be fixed up.
prev parent reply other threads:[~2007-12-09 8:52 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-12-09 3:07 Bogus commit 70eba18b ("make bnx2x select ZLIB_INFLATE")? Roland Dreier
2007-12-09 4:48 ` Jeff Garzik
2007-12-09 8:52 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20071209.005245.241039796.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=eliezert@broadcom.com \
--cc=jeff@garzik.org \
--cc=lee.schermerhorn@hp.com \
--cc=netdev@vger.kernel.org \
--cc=rdreier@cisco.com \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).