netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [IPv6] ESP: Discard dummy packets introduced in rfc4303
@ 2007-12-10 22:18 Thomas Graf
  2007-12-11  0:54 ` David Miller
  0 siblings, 1 reply; 2+ messages in thread
From: Thomas Graf @ 2007-12-10 22:18 UTC (permalink / raw)
  To: davem, herbert; +Cc: netdev

RFC4303 introduces dummy packets with a nexthdr value of 59
to implement traffic confidentiality. Such packets need to
be dropped silently and the payload may not be attempted to
be parsed as it consists of random chunk.

Signed-off-by: Thomas Graf <tgraf@suug.ch>

Index: net-2.6.25/net/ipv6/esp6.c
===================================================================
--- net-2.6.25.orig/net/ipv6/esp6.c	2007-12-10 16:06:02.000000000 +0100
+++ net-2.6.25/net/ipv6/esp6.c	2007-12-10 16:08:02.000000000 +0100
@@ -238,6 +238,12 @@
 		}
 		/* ... check padding bits here. Silly. :-) */
 
+		/* RFC4303: Drop dummy packets without any error */
+		if (nexthdr[1] == IPPROTO_NONE) {
+			ret = -EINVAL;
+			goto out;
+		}
+
 		pskb_trim(skb, skb->len - alen - padlen - 2);
 		ret = nexthdr[1];
 	}

^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [IPv6] ESP: Discard dummy packets introduced in rfc4303
  2007-12-10 22:18 [IPv6] ESP: Discard dummy packets introduced in rfc4303 Thomas Graf
@ 2007-12-11  0:54 ` David Miller
  0 siblings, 0 replies; 2+ messages in thread
From: David Miller @ 2007-12-11  0:54 UTC (permalink / raw)
  To: tgraf; +Cc: herbert, netdev

From: Thomas Graf <tgraf@suug.ch>
Date: Mon, 10 Dec 2007 23:18:07 +0100

> RFC4303 introduces dummy packets with a nexthdr value of 59
> to implement traffic confidentiality. Such packets need to
> be dropped silently and the payload may not be attempted to
> be parsed as it consists of random chunk.
> 
> Signed-off-by: Thomas Graf <tgraf@suug.ch>

Also applied to net-2.6, thanks Thomas.

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2007-12-11  0:54 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2007-12-10 22:18 [IPv6] ESP: Discard dummy packets introduced in rfc4303 Thomas Graf
2007-12-11  0:54 ` David Miller

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).