Re: [PATCH v2] XFRM: assorted IPsec fixups

[Paul Moore <paul.moore@hp.com>]

On Tuesday 11 December 2007 12:21:26 pm David Miller wrote:
> From: Paul Moore <paul.moore@hp.com>
> Date: Tue, 11 Dec 2007 12:15:00 -0500
>
> > I still would like to see the rest of the changes make it into
> > 2.6.25 (the SPI byte order thing is particularly troublesome) so if
> > you don't mind a "v3" I'll respin this patch right now to remove the
> > "sid -> secid" bits.
>
> Technically this could break anything parsing the audit logs, but no
> matter, I'd rather fix this now while we still can.

True, this does change how userspace sees things but I think that any 
userspace code that currently uses this SPI value successfully is either 
lucky or has a workaround/hack in place.

> I would classify the spi endianness bit as a bug fix, could you please
> just split out that fix for net-2.6, then we can make a second patch
> after I rebase net-2.6.25 which can do the rest of your patch sans the
> linux/xfrm.h change?

Sure.  Although that's enough of a change that I'd want to retest the patch a 
bit first.  If I can't get it done today expect something in your inbox 
tomorrow.

Thanks for your patience.

-- 
paul moore
linux security @ hp