From: Daniel Mack <daniel@caiaq.de>
To: netdev@vger.kernel.org
Subject: DM9000_IRQ_FLAGS
Date: Tue, 11 Dec 2007 20:18:23 +0100 [thread overview]
Message-ID: <20071211191823.GD15295@buzzloop.caiaq.de> (raw)
Hi,
on Toradex' Colibri, a PXA270 based board with a DM9000 ethernet
controller, this driver won't work due to unsuitable DM9000_IRQ_FLAGS.
If I understood the code behind request_irq() correctly, it's not
recommended to register an IRQ without any of the IRQT_* flags set.
Is there any concerns about applying the patch below?
Best regards,
Daniel
diff --git a/drivers/net/dm9000.c b/drivers/net/dm9000.c
index 3286d2a..6a20a54 100644
--- a/drivers/net/dm9000.c
+++ b/drivers/net/dm9000.c
@@ -66,6 +66,7 @@
#include <linux/dm9000.h>
#include <linux/delay.h>
#include <linux/platform_device.h>
+#include <linux/irq.h>
#include <asm/delay.h>
#include <asm/irq.h>
@@ -113,7 +114,7 @@
#define writesl outsl
#define DM9000_IRQ_FLAGS (IRQF_SHARED | IRQF_TRIGGER_HIGH)
#else
-#define DM9000_IRQ_FLAGS IRQF_SHARED
+#define DM9000_IRQ_FLAGS (IRQF_SHARED | IRQT_RISING)
#endif
/*
next reply other threads:[~2007-12-11 19:18 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-12-11 19:18 Daniel Mack [this message]
2007-12-11 20:31 ` DM9000_IRQ_FLAGS Remy Bohmer
2007-12-12 13:41 ` DM9000_IRQ_FLAGS Daniel Mack
2007-12-12 14:46 ` DM9000_IRQ_FLAGS Remy Bohmer
2007-12-12 15:01 ` DM9000_IRQ_FLAGS Daniel Mack
2007-12-20 9:46 ` DM9000_IRQ_FLAGS Ben Dooks
2007-12-20 9:54 ` DM9000_IRQ_FLAGS Remy Bohmer
2008-01-15 11:42 ` DM9000_IRQ_FLAGS Daniel Mack
2007-12-20 9:45 ` DM9000_IRQ_FLAGS Ben Dooks
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20071211191823.GD15295@buzzloop.caiaq.de \
--to=daniel@caiaq.de \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).