From: David Miller <davem@davemloft.net>
To: den@openvz.org
Cc: containers@lists.osdl.org, devel@openvz.org, netdev@vger.kernel.org
Subject: Re: [PATCH 2.6.25] IPv4: thresholds in fib_trie.c are not modified, make them const
Date: Wed, 12 Dec 2007 10:58:33 -0800 (PST) [thread overview]
Message-ID: <20071212.105833.237798467.davem@davemloft.net> (raw)
In-Reply-To: <20071212110555.GA11638@iris.sw.ru>
From: "Denis V. Lunev" <den@openvz.org>
Date: Wed, 12 Dec 2007 14:05:55 +0300
> -static int halve_threshold = 25;
> -static int inflate_threshold = 50;
> -static int halve_threshold_root = 15;
> -static int inflate_threshold_root = 25;
halve_threshold_root and inflate_threshold_root have different
values in the net-2.6.25 tree.
What tree are you patching against? These were changed way
back in:
commit 965ffea43d4ebe8cd7b9fee78d651268dd7d23c5
Author: Robert Olsson <robert.olsson@its.uu.se>
Date: Mon Mar 19 16:29:58 2007 -0700
[IPV4]: fib_trie root node settings
The threshold for root node can be more aggressive set to get
better tree compression. The new setting mekes the root grow
from 16 to 19 bits and substansial improvemnt in Aver depth
this with the current table of 214393 prefixes
But really the dynamic resize should need more investigation
both in terms convergence and performance and maybe it should
be possible to change...
Maybe just for the brave to start with or we may have to back
this out.
Please don't waste my time like this. Always submit patches
against the current tree, even if you "think" the files
you are patching haven't changed.
next prev parent reply other threads:[~2007-12-12 18:58 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-12-12 11:05 [PATCH 2.6.25] IPv4: thresholds in fib_trie.c are not modified, make them const Denis V. Lunev
2007-12-12 18:58 ` David Miller [this message]
2007-12-13 7:32 ` Denis V. Lunev
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20071212.105833.237798467.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=containers@lists.osdl.org \
--cc=den@openvz.org \
--cc=devel@openvz.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).