netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: David Miller <davem@davemloft.net>
To: herbert@gondor.apana.org.au
Cc: akpm@linux-foundation.org, ilpo.jarvinen@helsinki.fi,
	netdev@vger.kernel.org
Subject: Re: [IPSEC]: Fix reversed ICMP6 policy check
Date: Wed, 12 Dec 2007 18:54:46 -0800 (PST)	[thread overview]
Message-ID: <20071212.185446.112976256.davem@davemloft.net> (raw)
In-Reply-To: <20071213025155.GA784@gondor.apana.org.au>

From: Herbert Xu <herbert@gondor.apana.org.au>
Date: Thu, 13 Dec 2007 10:51:56 +0800

> You're too quick :) Before you ask for an incremental patch, here's
> a preemptive strike :)

Hehe :)

> [IPSEC]: Do not let packets pass when ICMP flag is off
> 
> This fixes a logical error in ICMP policy checks which lets
> packets through if the state ICMP flag is off.
> 
> Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>

Applied, thanks!

  reply	other threads:[~2007-12-13  2:54 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-12-13  0:21 net-2.6.25 splat Andrew Morton
2007-12-13  0:26 ` David Miller
2007-12-13  1:39   ` Andrew Morton
2007-12-13  1:58     ` [IPSEC]: Fix reversed ICMP6 policy check Herbert Xu
2007-12-13  2:48       ` David Miller
2007-12-13  2:51         ` Herbert Xu
2007-12-13  2:54           ` David Miller [this message]
2007-12-13  2:49       ` Herbert Xu
2007-12-13  2:51         ` David Miller
2007-12-13 11:19         ` Jarek Poplawski

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20071212.185446.112976256.davem@davemloft.net \
    --to=davem@davemloft.net \
    --cc=akpm@linux-foundation.org \
    --cc=herbert@gondor.apana.org.au \
    --cc=ilpo.jarvinen@helsinki.fi \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).