* [PATCH 2.6.25] netns: network namespace was passed into dev_getbyhwaddr but not used
@ 2007-12-12 11:05 Denis V. Lunev
2007-12-12 18:50 ` David Miller
0 siblings, 1 reply; 2+ messages in thread
From: Denis V. Lunev @ 2007-12-12 11:05 UTC (permalink / raw)
To: davem; +Cc: containers, devel, netdev
netns: network namespace was passed into dev_getbyhwaddr but not used
Signed-off-by: Denis V. Lunev <den@openvz.org>
diff --git a/net/core/dev.c b/net/core/dev.c
index 06615df..677f35b 100644
--- a/net/core/dev.c
+++ b/net/core/dev.c
@@ -675,7 +675,7 @@ struct net_device *dev_getbyhwaddr(struct net *net, unsigned short type, char *h
ASSERT_RTNL();
- for_each_netdev(&init_net, dev)
+ for_each_netdev(net, dev)
if (dev->type == type &&
!memcmp(dev->dev_addr, ha, dev->addr_len))
return dev;
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH 2.6.25] netns: network namespace was passed into dev_getbyhwaddr but not used
2007-12-12 11:05 [PATCH 2.6.25] netns: network namespace was passed into dev_getbyhwaddr but not used Denis V. Lunev
@ 2007-12-12 18:50 ` David Miller
0 siblings, 0 replies; 2+ messages in thread
From: David Miller @ 2007-12-12 18:50 UTC (permalink / raw)
To: den; +Cc: containers, devel, netdev
From: "Denis V. Lunev" <den@openvz.org>
Date: Wed, 12 Dec 2007 14:05:17 +0300
> netns: network namespace was passed into dev_getbyhwaddr but not used
>
> Signed-off-by: Denis V. Lunev <den@openvz.org>
Applied.
Please always put the subsystem name in the headline in
all capitals and surround it with brackets, like this:
[NETNS]: Blah blah blah.
Also treat the description line as a true English sentence, this means
capitalize the first word and put a period at the end of it. This is
a changelog message for a professional piece of software, not some
"innanet" slang talk on some IRC channel. :-)
I make these edits to every one of your patch submissions and it's
getting tiring, I hoped you would notice this yourself before my
needing to tell you about it explicitly :-)
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2007-12-12 18:50 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2007-12-12 11:05 [PATCH 2.6.25] netns: network namespace was passed into dev_getbyhwaddr but not used Denis V. Lunev
2007-12-12 18:50 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).