From: David Miller <davem@davemloft.net>
To: adobriyan@sw.ru
Cc: den@openvz.org, containers@lists.osdl.org,
netdev@vger.kernel.org, devel@openvz.org
Subject: Re: [Devel] [PATCH 2.6.25] [IPV4] Reduce whitespaces in fib_rules.h.
Date: Thu, 13 Dec 2007 06:49:55 -0800 (PST) [thread overview]
Message-ID: <20071213.064955.91784038.davem@davemloft.net> (raw)
In-Reply-To: <20071213144707.GB6209@localhost.sw.ru>
From: Alexey Dobriyan <adobriyan@sw.ru>
Date: Thu, 13 Dec 2007 17:47:07 +0300
> On Thu, Dec 13, 2007 at 05:18:42PM +0300, Denis V. Lunev wrote:
> > There are to many spaces between type and function name in the declaration
> > of fib rules manipulation routines. Eat them and save a couple of lines.
>
> If this patch is going in, it would be nice to get rid of "extern" as
> well.
The convention in the networking headers is to use extern, and
this is pretty consistently done across the board.
If we are going to do this, which I personally see no reason
for, we should do it across the whole networking.
Consistency is much more important than whatever reason you
could come up with to get rid of the 'extern'.
next prev parent reply other threads:[~2007-12-13 14:49 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-12-13 14:18 [PATCH 2.6.25] [IPV4] Reduce whitespaces in fib_rules.h Denis V. Lunev
[not found] ` <20071213141842.GA9939-aPCOdVxUTlgvJsYlp49lxw@public.gmane.org>
2007-12-13 14:47 ` [Devel] " Alexey Dobriyan
2007-12-13 14:49 ` David Miller [this message]
2007-12-13 14:50 ` David Miller
2007-12-13 15:01 ` Denis V. Lunev
2007-12-13 15:00 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20071213.064955.91784038.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=adobriyan@sw.ru \
--cc=containers@lists.osdl.org \
--cc=den@openvz.org \
--cc=devel@openvz.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).