From: David Miller <davem@davemloft.net>
To: mschmidt@redhat.com
Cc: netdev@vger.kernel.org, kaber@trash.net, mmaslano@redhat.com
Subject: Re: [patch 2/2] ipv6/sit: Rebinding of SIT tunnels to other interfaces
Date: Thu, 13 Dec 2007 09:47:28 -0800 (PST) [thread overview]
Message-ID: <20071213.094728.163398057.davem@davemloft.net> (raw)
In-Reply-To: <20071213133922.468540197@redhat.com>
From: mschmidt@redhat.com
Date: Thu, 13 Dec 2007 14:37:50 +0100
> This is similar to the change already done for IPIP tunnels.
>
> Once created, a SIT tunnel can't be bound to another device.
> To reproduce:
>
> # create a tunnel:
> ip tunnel add tunneltest0 mode sit remote 10.0.0.1 dev eth0
> # try to change the bounding device from eth0 to eth1:
> ip tunnel change tunneltest0 dev eth1
> # show the result:
> ip tunnel show tunneltest0
>
> tunneltest0: ipv6/ip remote 10.0.0.1 local any dev eth0 ttl inherit
>
> Notice the bound device has not changed from eth0 to eth1.
>
> This patch fixes it. When changing the binding, it also recalculates the
> MTU according to the new bound device's MTU.
>
> Signed-off-by: Michal Schmidt <mschmidt@redhat.com>
Also applied, thanks.
prev parent reply other threads:[~2007-12-13 17:47 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-12-13 13:37 [patch 0/2] rebinding tunnels to interfaces mschmidt
2007-12-13 13:37 ` [patch 1/2] ip_gre: Rebinding of GRE tunnels to other interfaces mschmidt
2007-12-13 17:47 ` David Miller
2007-12-13 13:37 ` [patch 2/2] ipv6/sit: Rebinding of SIT " mschmidt
2007-12-13 17:47 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20071213.094728.163398057.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=kaber@trash.net \
--cc=mmaslano@redhat.com \
--cc=mschmidt@redhat.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).