* [PATCH 2.6.25] [IPV4] Thresholds in fib_trie.c are used as consts, so make them const.
@ 2007-12-13 8:06 Denis V. Lunev
2007-12-13 17:48 ` David Miller
0 siblings, 1 reply; 2+ messages in thread
From: Denis V. Lunev @ 2007-12-13 8:06 UTC (permalink / raw)
To: davem; +Cc: containers, devel, netdev
[IPV4] Thresholds in fib_trie.c are used as consts, so make them const.
There are several thresholds for trie fib hash management. They are used
in the code as a constants. Make them constants from the compiler point of
view.
Signed-off-by: Denis V. Lunev <den@openvz.org>
---
diff --git a/net/ipv4/fib_trie.c b/net/ipv4/fib_trie.c
--- a/net/ipv4/fib_trie.c
+++ b/net/ipv4/fib_trie.c
@@ -299,10 +299,10 @@ static inline void check_tnode(const struct tnode *tn)
WARN_ON(tn && tn->pos+tn->bits > 32);
}
-static int halve_threshold = 25;
-static int inflate_threshold = 50;
-static int halve_threshold_root = 8;
-static int inflate_threshold_root = 15;
+static const int halve_threshold = 25;
+static const int inflate_threshold = 50;
+static const int halve_threshold_root = 8;
+static const int inflate_threshold_root = 15;
static void __alias_free_mem(struct rcu_head *head)
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH 2.6.25] [IPV4] Thresholds in fib_trie.c are used as consts, so make them const.
2007-12-13 8:06 [PATCH 2.6.25] [IPV4] Thresholds in fib_trie.c are used as consts, so make them const Denis V. Lunev
@ 2007-12-13 17:48 ` David Miller
0 siblings, 0 replies; 2+ messages in thread
From: David Miller @ 2007-12-13 17:48 UTC (permalink / raw)
To: den; +Cc: containers, devel, netdev
From: "Denis V. Lunev" <den@openvz.org>
Date: Thu, 13 Dec 2007 11:06:18 +0300
> [IPV4] Thresholds in fib_trie.c are used as consts, so make them const.
>
> There are several thresholds for trie fib hash management. They are used
> in the code as a constants. Make them constants from the compiler point of
> view.
>
> Signed-off-by: Denis V. Lunev <den@openvz.org>
Applied, thanks for fixing this patch up.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2007-12-13 17:48 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2007-12-13 8:06 [PATCH 2.6.25] [IPV4] Thresholds in fib_trie.c are used as consts, so make them const Denis V. Lunev
2007-12-13 17:48 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).