netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Andrew Morton <akpm@linux-foundation.org>
To: "Ayaz Abdulla" <AAbdulla@nvidia.com>
Cc: jeff@garzik.org, netdev@vger.kernel.org, eswierk@arastra.com
Subject: Re: [patch 02/10] forcedeth: power down phy when interface is down
Date: Thu, 13 Dec 2007 16:30:46 -0800	[thread overview]
Message-ID: <20071213163046.c2e9d340.akpm@linux-foundation.org> (raw)
In-Reply-To: <F72FA20C31DD4F4C997B91C5B3690A091A990D@hqemmail07.nvidia.com>

On Thu, 13 Dec 2007 16:11:55 -0800
"Ayaz Abdulla" <AAbdulla@nvidia.com> wrote:

> I would not include this patch until further testing is performed.
> NVIDIA MCP chips use 3rd party PHY vendors. By powering down the phy, it
> could have adverse affects on certain phys.
> 
> Ayaz
> 
> 
> -----Original Message-----
> From: akpm@linux-foundation.org [mailto:akpm@linux-foundation.org] 
> Sent: Thursday, December 13, 2007 4:03 PM
> To: jeff@garzik.org
> Cc: netdev@vger.kernel.org; akpm@linux-foundation.org;
> eswierk@arastra.com; Ayaz Abdulla
> Subject: [patch 02/10] forcedeth: power down phy when interface is down
> 
> 
> From: "Ed Swierk" <eswierk@arastra.com>
> 
> Bring the physical link down when the interface is down by placing the
> PHY
> in power-down state, unless WOL is enabled.  This mirrors the behavior
> of
> other drivers including e1000 and tg3.

Does this patch actually fix any observeable problem?

  reply	other threads:[~2007-12-14  0:31 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-12-14  0:02 [patch 02/10] forcedeth: power down phy when interface is down akpm
2007-12-14  0:11 ` Ayaz Abdulla
2007-12-14  0:30   ` Andrew Morton [this message]
2007-12-14  0:51     ` Brandeburg, Jesse
2007-12-14  0:53     ` Ed Swierk
2007-12-14  1:07       ` Andrew Morton
2007-12-14 20:30         ` Ayaz Abdulla

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20071213163046.c2e9d340.akpm@linux-foundation.org \
    --to=akpm@linux-foundation.org \
    --cc=AAbdulla@nvidia.com \
    --cc=eswierk@arastra.com \
    --cc=jeff@garzik.org \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).