From mboxrd@z Thu Jan 1 00:00:00 1970 From: Andrew Morton Subject: Re: [patch 04/10] ucc_geth-fix-build-break-introduced-by-commit-09f75cd7bf13720738e6a196cc0107ce9a5bd5a0-checkpatch-fixes Date: Fri, 14 Dec 2007 15:27:48 -0800 Message-ID: <20071214152748.8a44379b.akpm@linux-foundation.org> References: <200712140002.lBE02tBW025520@imap1.linux-foundation.org> <4762F218.7040904@garzik.org> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Cc: netdev@vger.kernel.org, Emilian.Medve@Freescale.com, davem@davemloft.net, galak@gate.crashing.org, leoli@Freescale.com, paulus@samba.org To: Jeff Garzik Return-path: Received: from smtp2.linux-foundation.org ([207.189.120.14]:36392 "EHLO smtp2.linux-foundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752367AbXLNX2e (ORCPT ); Fri, 14 Dec 2007 18:28:34 -0500 In-Reply-To: <4762F218.7040904@garzik.org> Sender: netdev-owner@vger.kernel.org List-ID: On Fri, 14 Dec 2007 16:14:00 -0500 Jeff Garzik wrote: > akpm@linux-foundation.org wrote: > > From: Andrew Morton > > > > Cc: "David S. Miller" > > Cc: Emil Medve > > Cc: Jeff Garzik > > Cc: Kumar Gala > > Cc: Li Yang > > Cc: Paul Mackerras > > Signed-off-by: Andrew Morton > > --- > > > > drivers/net/ucc_geth.c | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff -puN drivers/net/ucc_geth.c~ucc_geth-fix-build-break-introduced-by-commit-09f75cd7bf13720738e6a196cc0107ce9a5bd5a0-checkpatch-fixes drivers/net/ucc_geth.c > > --- a/drivers/net/ucc_geth.c~ucc_geth-fix-build-break-introduced-by-commit-09f75cd7bf13720738e6a196cc0107ce9a5bd5a0-checkpatch-fixes > > +++ a/drivers/net/ucc_geth.c > > @@ -3447,7 +3447,7 @@ static int ucc_geth_rx(struct ucc_geth_p > > u16 length, howmany = 0; > > u32 bd_status; > > u8 *bdBuffer; > > - struct net_device * dev; > > + struct net_device *dev; > > > > ugeth_vdbg("%s: IN", __FUNCTION__); > > applied this crucial fix to #upstream-fixes with a suitable changelog > heh. I meant to drop that - the patch machine gets unreliable when it needs human intervention.