netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: David Miller <davem@davemloft.net>
To: herbert@gondor.apana.org.au
Cc: akpm@linux-foundation.org, netdev@vger.kernel.org, ebiederm@xmission.com
Subject: Re: [patch 2/4] net: use mutex_is_locked() for ASSERT_RTNL()
Date: Sat, 15 Dec 2007 21:44:29 -0800 (PST)	[thread overview]
Message-ID: <20071215.214429.121871076.davem@davemloft.net> (raw)
In-Reply-To: <20071215131016.GA28705@gondor.apana.org.au>

From: Herbert Xu <herbert@gondor.apana.org.au>
Date: Sat, 15 Dec 2007 21:10:16 +0800

> On Sat, Dec 15, 2007 at 02:48:10AM -0800, Andrew Morton wrote:
> >
> > Now as a separate issue we (ie: you) need to work out what _other_ things
> > you want ASSERT_RTNL to check apart from "rtnl must be held".
> 
> Since we have now established that ASSERT_RTNL never actually
> warned about usage on paths with BH off, I think Eric's original
> patch is fine as it is and I owe him an apology.

Ok, same here...

Such situations (ASSERT_RTNL() in atomic context) have always
been bugs though, and that continues to be true and I think
the check should be added somehow.

  reply	other threads:[~2007-12-16  5:44 UTC|newest]

Thread overview: 24+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-12-14  0:02 [patch 2/4] net: use mutex_is_locked() for ASSERT_RTNL() akpm
2007-12-14  8:10 ` Herbert Xu
2007-12-14  8:22   ` Andrew Morton
2007-12-14  8:30     ` Herbert Xu
2007-12-14 19:15       ` David Miller
2007-12-14 23:11         ` Andrew Morton
2007-12-15  4:18           ` Herbert Xu
2007-12-15  5:44             ` Andrew Morton
2007-12-15  6:10               ` Herbert Xu
2007-12-15 10:48                 ` Andrew Morton
2007-12-15 13:10                   ` Herbert Xu
2007-12-16  5:44                     ` David Miller [this message]
2007-12-16  7:13                       ` Herbert Xu
2007-12-16 18:06                   ` Jarek Poplawski
2007-12-17  1:26                     ` Herbert Xu
2007-12-17  7:26                       ` Jarek Poplawski
2007-12-17  7:31                         ` Herbert Xu
2007-12-17  7:57                           ` Jarek Poplawski
2007-12-17  7:44                         ` Jarek Poplawski
2007-12-16  5:37               ` David Miller
2007-12-14 12:37     ` Johannes Berg
2007-12-14 12:46       ` Herbert Xu
2007-12-14 12:54         ` Johannes Berg
2007-12-14 19:30 ` David Miller

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20071215.214429.121871076.davem@davemloft.net \
    --to=davem@davemloft.net \
    --cc=akpm@linux-foundation.org \
    --cc=ebiederm@xmission.com \
    --cc=herbert@gondor.apana.org.au \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).