From: Ingo Molnar <mingo@elte.hu>
To: Herbert Xu <herbert@gondor.apana.org.au>
Cc: Alexey Kuznetsov <kuznet@ms2.inr.ac.ru>,
Wang Chen <wangchen@cn.fujitsu.com>,
Gerrit Renker <gerrit@erg.abdn.ac.uk>,
davem@davemloft.net, andi@firstfloor.org, netdev@vger.kernel.org,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Christoph Lameter <clameter@sgi.com>
Subject: Re: [PATCH 3/3] [UDP6]: Counter increment on BH mode
Date: Sun, 16 Dec 2007 09:58:18 +0100 [thread overview]
Message-ID: <20071216085818.GA27280@elte.hu> (raw)
In-Reply-To: <20071216023621.GB959@gondor.apana.org.au>
* Herbert Xu <herbert@gondor.apana.org.au> wrote:
> On Sat, Dec 15, 2007 at 07:43:28PM +0100, Ingo Molnar wrote:
> >
> > we could perhaps introduce stat_smp_processor_id(), which signals that
> > the CPU id is used for statistical purposes and does not have to be
> > exact? In any case, your patch looks good too.
>
> Unfortunately that doesn't work because we can then have two CPUs
> trying to update the same counter which may corrupt it.
ah, indeed. I missed that correctness aspect of your patch. Good catch!
Ingo
next prev parent reply other threads:[~2007-12-16 8:58 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-11-30 3:09 [PATCH 1/3] [SNMP]: Defer InDataGrams increment until recvmsg() does checksum Wang Chen
2007-11-30 3:15 ` [PATCH 2/3] [UDP]: Clean up for IS_UDPLITE macro Wang Chen
2007-11-30 11:05 ` Gerrit Renker
2007-11-30 3:24 ` [PATCH 3/3] [UDP6]: Counter increment on BH mode Wang Chen
2007-11-30 11:19 ` Gerrit Renker
2007-12-01 1:54 ` Herbert Xu
2007-12-03 7:19 ` Wang Chen
2007-12-03 11:39 ` Herbert Xu
2007-12-03 11:49 ` Alexey Kuznetsov
2007-12-03 11:54 ` Herbert Xu
2007-12-03 13:17 ` Herbert Xu
2007-12-04 3:50 ` Wang Chen
2007-12-04 3:57 ` Herbert Xu
2007-12-15 13:58 ` Herbert Xu
2007-12-15 17:03 ` Eric Dumazet
2007-12-16 2:30 ` [SNMP]: Fix SNMP counters with PREEMPT Herbert Xu
2007-12-20 12:13 ` David Miller
2007-12-15 18:43 ` [PATCH 3/3] [UDP6]: Counter increment on BH mode Ingo Molnar
2007-12-16 2:36 ` Herbert Xu
2007-12-16 8:58 ` Ingo Molnar [this message]
2007-12-17 19:42 ` Christoph Lameter
2007-12-17 19:40 ` Christoph Lameter
2007-12-18 11:43 ` Gerrit Renker
2007-12-18 12:49 ` Herbert Xu
2007-12-20 12:12 ` David Miller
2007-11-30 10:57 ` [PATCH 1/3] [SNMP]: Defer InDataGrams increment until recvmsg() does checksum Gerrit Renker
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20071216085818.GA27280@elte.hu \
--to=mingo@elte.hu \
--cc=andi@firstfloor.org \
--cc=clameter@sgi.com \
--cc=davem@davemloft.net \
--cc=gerrit@erg.abdn.ac.uk \
--cc=herbert@gondor.apana.org.au \
--cc=kuznet@ms2.inr.ac.ru \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=wangchen@cn.fujitsu.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).