From: Evgeniy Polyakov <johnpol@2ka.mipt.ru>
To: Stephen Hemminger <shemminger@linux-foundation.org>
Cc: Meelis Roos <mroos@linux.ee>, netdev@vger.kernel.org
Subject: Re: Badness at net/core/dev.c:2199
Date: Sun, 16 Dec 2007 21:46:37 +0300 [thread overview]
Message-ID: <20071216184637.GA20871@2ka.mipt.ru> (raw)
In-Reply-To: <20071216103340.07479359@deepthought>
On Sun, Dec 16, 2007 at 10:33:40AM -0800, Stephen Hemminger (shemminger@linux-foundation.org) wrote:
> > index 3653314..9e0e97a 100644
> > --- a/drivers/net/tulip/interrupt.c
> > +++ b/drivers/net/tulip/interrupt.c
> > @@ -151,8 +151,9 @@ int tulip_poll(struct napi_struct *napi, int budget)
> > if (tulip_debug > 5)
> > printk(KERN_DEBUG "%s: In tulip_rx(), entry %d %8.8x.\n",
> > dev->name, entry, status);
> > - if (work_done++ >= budget)
> > + if (work_done >= budget)
> > goto not_done;
> > + work_done++;
> >
> > if ((status & 0x38008300) != 0x0300) {
> > if ((status & 0x38000300) != 0x0300) {
> >
> >
>
> I already sendout a correct patch last week. It should pre-increment.
That will work too.
Thanks Stephen.
--
Evgeniy Polyakov
next prev parent reply other threads:[~2007-12-16 18:47 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-12-16 17:55 Badness at net/core/dev.c:2199 Meelis Roos
2007-12-16 18:20 ` Evgeniy Polyakov
2007-12-16 18:33 ` Stephen Hemminger
2007-12-16 18:46 ` Evgeniy Polyakov [this message]
2007-12-20 10:57 ` Meelis Roos
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20071216184637.GA20871@2ka.mipt.ru \
--to=johnpol@2ka.mipt.ru \
--cc=mroos@linux.ee \
--cc=netdev@vger.kernel.org \
--cc=shemminger@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).