netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: David Miller <davem-fT/PcQaiUtIeIZ0/mPfg9Q@public.gmane.org>
To: linville-2XuSBdqkA4R54TAoqtyWWQ@public.gmane.org
Cc: jeff-o2qLIJkoznsdnm+yROfE0A@public.gmane.org,
	netdev-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	linux-wireless-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Subject: Re: Please pull 'fixes-jgarzik' branch of wireless-2.6
Date: Mon, 17 Dec 2007 12:07:48 -0800 (PST)	[thread overview]
Message-ID: <20071217.120748.51571249.davem@davemloft.net> (raw)
In-Reply-To: <20071217193402.GD3121-2XuSBdqkA4R54TAoqtyWWQ@public.gmane.org>

From: "John W. Linville" <linville-2XuSBdqkA4R54TAoqtyWWQ@public.gmane.org>
Date: Mon, 17 Dec 2007 14:34:02 -0500

> On Sat, Dec 15, 2007 at 11:31:48PM -0500, John W. Linville wrote:
> 
> > Cyrill Gorcunov (2):
> >       ieee80211_rate: missed unlock
> 
> >  net/mac80211/ieee80211_rate.c                  |    1 +
> 
> > diff --git a/net/mac80211/ieee80211_rate.c b/net/mac80211/ieee80211_rate.c
> > index 7254bd6..3260a4a 100644
> > --- a/net/mac80211/ieee80211_rate.c
> > +++ b/net/mac80211/ieee80211_rate.c
> > @@ -33,6 +33,7 @@ int ieee80211_rate_control_register(struct rate_control_ops *ops)
> >  		if (!strcmp(alg->ops->name, ops->name)) {
> >  			/* don't register an algorithm twice */
> >  			WARN_ON(1);
> > +			mutex_unlock(&rate_ctrl_mutex);
> >  			return -EALREADY;
> >  		}
> >  	}
> 
> Crud...there is a one-line fix in here that should have gone to Dave.
> 
> Jeff, (assuming Dave ACKs it) would you mind just taking it your
> way along with the other posted patches?  Since this is intended for
> 2.6.24, there should be no great maintenance hardship if it goes to
> Linus through your tree instead of Dave's.

It's totally fine if Jeff takes this, don't worry so much about
it :-)

And yes the change looks fine to me too :)

  parent reply	other threads:[~2007-12-17 20:07 UTC|newest]

Thread overview: 27+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-12-16  4:31 Please pull 'fixes-jgarzik' branch of wireless-2.6 John W. Linville
2007-12-17 19:34 ` John W. Linville
     [not found]   ` <20071217193402.GD3121-2XuSBdqkA4R54TAoqtyWWQ@public.gmane.org>
2007-12-17 20:07     ` David Miller [this message]
2007-12-17 20:18     ` Jeff Garzik
     [not found] ` <20071216043148.GE3096-2XuSBdqkA4R54TAoqtyWWQ@public.gmane.org>
2007-12-17 21:10   ` Jeff Garzik
  -- strict thread matches above, loose matches on Subject: below --
2008-01-16 21:27 John W. Linville
2008-01-18 19:40 ` Jeff Garzik
2008-01-10 19:49 John W. Linville
     [not found] ` <20080110194922.GF3109-2XuSBdqkA4R54TAoqtyWWQ@public.gmane.org>
2008-01-10 20:57   ` John W. Linville
2008-01-08  5:15 John W. Linville
2008-01-08  6:04 ` David Miller
2007-12-20 15:54 John W. Linville
2007-11-30  3:29 John W. Linville
     [not found] ` <20071130032917.GA29165-2XuSBdqkA4R54TAoqtyWWQ@public.gmane.org>
2007-12-01 21:20   ` Jeff Garzik
2007-11-06 20:07 John W. Linville
     [not found] ` <20071106200700.GF4440-2XuSBdqkA4R54TAoqtyWWQ@public.gmane.org>
2007-11-07 19:13   ` John W. Linville
     [not found]     ` <20071107191329.GC30169-2XuSBdqkA4R54TAoqtyWWQ@public.gmane.org>
2007-11-07 19:24       ` Jeff Garzik
2007-10-26  3:08 John W. Linville
2007-10-29  9:48 ` Jeff Garzik
2007-10-18 22:09 John W. Linville
     [not found] ` <20071018220946.GH8510-2XuSBdqkA4R54TAoqtyWWQ@public.gmane.org>
2007-10-20  3:04   ` Jeff Garzik
2007-10-03  1:20 John W. Linville
2007-10-03 17:39 ` Jeff Garzik
2007-09-15 13:14 John W. Linville
2007-09-15 23:29 ` Jeff Garzik
2007-08-06 20:14 John W. Linville
     [not found] ` <20070806201441.GJ6442-2XuSBdqkA4R54TAoqtyWWQ@public.gmane.org>
2007-08-07 21:25   ` Jeff Garzik

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20071217.120748.51571249.davem@davemloft.net \
    --to=davem-ft/pcqaiutieiz0/mpfg9q@public.gmane.org \
    --cc=jeff-o2qLIJkoznsdnm+yROfE0A@public.gmane.org \
    --cc=linux-wireless-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=linville-2XuSBdqkA4R54TAoqtyWWQ@public.gmane.org \
    --cc=netdev-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).