From: Stephen Hemminger <shemminger@linux-foundation.org>
To: Eric Dumazet <dada1@cosmosbay.com>
Cc: "parag.warudkar@gmail.com" <parag.warudkar@gmail.com>,
linux-kernel@vger.kernel.org, David Miller <davem@davemloft.net>,
"netdev@vger.kernel.org" <netdev@vger.kernel.org>
Subject: Re: init_timer_deferrable conversion
Date: Mon, 17 Dec 2007 09:00:00 -0800 [thread overview]
Message-ID: <20071217090000.64499fba@deepthought> (raw)
In-Reply-To: <20071217152943.10470215.dada1@cosmosbay.com>
On Mon, 17 Dec 2007 15:29:43 +0100
Eric Dumazet <dada1@cosmosbay.com> wrote:
> On Mon, 17 Dec 2007 09:55:04 +0100
> Eric Dumazet <dada1@cosmosbay.com> wrote:
>
> > On Sun, 16 Dec 2007 22:00:23 -0500 (EST)
> > Parag Warudkar <parag.warudkar@gmail.com> wrote:
> >
> > > In my quest to get the wake-ups from idle per second down to bare minimum,
> > > I noticed 3 places in the kernel that could benefit from
> > > using init_timer_deferrable() instead of init_timer() -
> > >
> > > a) drivers/net/sky2.c - watchdog_timer. This was showing up high on
> > > Powertop's list of things that cause routine wakeups from idle. After
> > > converting to init_timer_deferrable() the wakeups went down and this one
> > > no longer shows up in powertop's list. 25% reduction.
This surprises me because it is a 1 hz timer and uses round_jiffies() in
the current kernel.
--
Stephen Hemminger <shemminger@linux-foundation.org>
next prev parent reply other threads:[~2007-12-17 17:00 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <Pine.LNX.4.64.0712162149220.4622@mini.warudkars.net>
2007-12-17 8:55 ` init_timer_deferrable conversion Eric Dumazet
2007-12-17 14:29 ` Eric Dumazet
2007-12-17 17:00 ` Stephen Hemminger [this message]
2007-12-17 17:47 ` Parag Warudkar
2007-12-17 18:13 ` Stephen Hemminger
2007-12-17 18:37 ` Parag Warudkar
2007-12-18 6:09 ` Parag Warudkar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20071217090000.64499fba@deepthought \
--to=shemminger@linux-foundation.org \
--cc=dada1@cosmosbay.com \
--cc=davem@davemloft.net \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=parag.warudkar@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).