From: Stephen Hemminger <shemminger@linux-foundation.org>
To: David Miller <davem@davemloft.net>
Cc: joonwpark81@gmail.com, netdev@vger.kernel.org, jgarzik@pobox.com,
baum@tehutinetworks.net, andy@greyhouse.net
Subject: Re: [RFT] tehuti: napi fix
Date: Mon, 17 Dec 2007 12:18:43 -0800 [thread overview]
Message-ID: <20071217121843.6ef76f05@deepthought> (raw)
In-Reply-To: <20071216.133833.105913775.davem@davemloft.net>
On Sun, 16 Dec 2007 13:38:33 -0800 (PST)
David Miller <davem@davemloft.net> wrote:
> From: Stephen Hemminger <shemminger@linux-foundation.org>
> Date: Wed, 12 Dec 2007 13:58:52 -0800
>
> > This should fix the tehuti napi fence post problems by getting
> > rid of priv->napi_stop, and setting weight to 32 (like other 10G).
> >
> > Also, used the wierd entry/exit macro's like rest of driver.
>
> It fixes the fench-post problem, but like the comments you
> removed explain:
>
> > - /* from time to time we exit to let NAPI layer release
> > - * device lock and allow waiting tasks (eg rmmod) to advance) */
> > - priv->napi_stop = 0;
> > -
>
> We now hang on rmmod during constant packet load.
>
> This change just trades one bug for another, we have to
> get the device close issue sorted out before we can go
> around removing these things.
Well the napi_stop had the same effect as having a smaller weight
value, so my patch just shrunk the weight. That causes the device
to exit NAPI (and should solve the rmmod problem).
--
Stephen Hemminger <stephen.hemminger@vyatta.com>
next prev parent reply other threads:[~2007-12-17 20:20 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-12-12 4:01 [PATCH 6/7] : tehuti Fix possible causing oops of net_rx_action Joonwoo Park
2007-12-12 5:39 ` Stephen Hemminger
2007-12-12 5:46 ` [RFC] net: napi fix Stephen Hemminger
2007-12-12 6:05 ` Joonwoo Park
2007-12-12 15:22 ` David Miller
2007-12-12 15:21 ` David Miller
2007-12-12 5:48 ` [PATCH 6/7] : tehuti Fix possible causing oops of net_rx_action Joonwoo Park
2007-12-12 5:53 ` Stephen Hemminger
2007-12-12 15:20 ` [PATCH 6/7] [NETDEV]: " David Miller
2007-12-12 16:36 ` Stephen Hemminger
2007-12-12 15:18 ` [PATCH 6/7] : " David Miller
2007-12-12 21:58 ` [RFT] tehuti: napi fix Stephen Hemminger
2007-12-16 21:38 ` David Miller
2007-12-17 20:18 ` Stephen Hemminger [this message]
2007-12-13 7:07 ` [PATCH 6/7] : tehuti Fix possible causing oops of net_rx_action Joonwoo Park
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20071217121843.6ef76f05@deepthought \
--to=shemminger@linux-foundation.org \
--cc=andy@greyhouse.net \
--cc=baum@tehutinetworks.net \
--cc=davem@davemloft.net \
--cc=jgarzik@pobox.com \
--cc=joonwpark81@gmail.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).