From mboxrd@z Thu Jan 1 00:00:00 1970 From: Stephen Hemminger Subject: Re: [RFT] tehuti: napi fix Date: Mon, 17 Dec 2007 12:18:43 -0800 Message-ID: <20071217121843.6ef76f05@deepthought> References: <002901c83c73$b089b6e0$9c94fea9@jason> <20071212.071832.07747779.davem@davemloft.net> <20071212135852.3369c820@freepuppy.rosehill> <20071216.133833.105913775.davem@davemloft.net> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Cc: joonwpark81@gmail.com, netdev@vger.kernel.org, jgarzik@pobox.com, baum@tehutinetworks.net, andy@greyhouse.net To: David Miller Return-path: Received: from smtp2.linux-foundation.org ([207.189.120.14]:59704 "EHLO smtp2.linux-foundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756868AbXLQUUf (ORCPT ); Mon, 17 Dec 2007 15:20:35 -0500 In-Reply-To: <20071216.133833.105913775.davem@davemloft.net> Sender: netdev-owner@vger.kernel.org List-ID: On Sun, 16 Dec 2007 13:38:33 -0800 (PST) David Miller wrote: > From: Stephen Hemminger > Date: Wed, 12 Dec 2007 13:58:52 -0800 > > > This should fix the tehuti napi fence post problems by getting > > rid of priv->napi_stop, and setting weight to 32 (like other 10G). > > > > Also, used the wierd entry/exit macro's like rest of driver. > > It fixes the fench-post problem, but like the comments you > removed explain: > > > - /* from time to time we exit to let NAPI layer release > > - * device lock and allow waiting tasks (eg rmmod) to advance) */ > > - priv->napi_stop = 0; > > - > > We now hang on rmmod during constant packet load. > > This change just trades one bug for another, we have to > get the device close issue sorted out before we can go > around removing these things. Well the napi_stop had the same effect as having a smaller weight value, so my patch just shrunk the weight. That causes the device to exit NAPI (and should solve the rmmod problem). -- Stephen Hemminger