From: Jouni Malinen <j@w1.fi>
To: Johannes Berg <johannes@sipsolutions.net>
Cc: "John W. Linville" <linville@tuxdriver.com>,
linux-wireless <linux-wireless@vger.kernel.org>,
netdev <netdev@vger.kernel.org>,
Michael Wu <flamingice@sourmilk.net>,
Tomas Winkler <tomasw@gmail.com>
Subject: Re: [RFC] mac80211: clean up frame receive handling
Date: Mon, 17 Dec 2007 20:22:53 -0800 [thread overview]
Message-ID: <20071218042253.GC5698@jm.kir.nu> (raw)
In-Reply-To: <1197634443.16079.36.camel@johannes.berg>
On Fri, Dec 14, 2007 at 01:14:03PM +0100, Johannes Berg wrote:
> I think in theory all eapol frames are sent to the PAE group address,
> but I have no idea which of the checks would be more efficient. It seems
> that the first could be optimised a lot because it's constant too...
They are not.. PAE group address is used for all EAPOL frames in
non-shared media LANs (e.g., wired Ethernet switch), but IEEE 802.11
uses the specific MAC address of the PAE since it is a shared media LAN
(i.e., the frames are between the unicast MAC address of the non-AP
STA/Supplicant and AP/Authenticator). If we end up having to drop the
PAE group addressed EAPOL frames in mac80211 anyway due to Linux
bridging code not doing this, we could combine these two validations and
just accept the unicast MAC address of the device itself as a valid
destination address for received EAPOL frames (and as the only valid
source address for transmitted ones).
--
Jouni Malinen PGP id EFC895FA
next prev parent reply other threads:[~2007-12-18 4:24 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-12-12 18:24 [RFC] mac80211: clean up frame receive handling Johannes Berg
[not found] ` <1197483844.6558.158.camel-YfaajirXv214zXjbi5bjpg@public.gmane.org>
2007-12-12 18:39 ` drago01
[not found] ` <f6ca9fed0712121039n1c287f48n7ece3107bd0b50ca-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2007-12-13 11:35 ` Johannes Berg
2007-12-13 20:49 ` John W. Linville
2007-12-14 12:14 ` Johannes Berg
2007-12-18 4:22 ` Jouni Malinen [this message]
[not found] ` <20071218042253.GC5698-mgr6C1c9aYeHXe+LvDLADg@public.gmane.org>
2007-12-18 12:42 ` Johannes Berg
2007-12-14 5:08 ` Jouni Malinen
[not found] ` <20071214050808.GE5698-mgr6C1c9aYeHXe+LvDLADg@public.gmane.org>
2007-12-14 12:13 ` Johannes Berg
[not found] ` <1197634385.16079.34.camel-YfaajirXv214zXjbi5bjpg@public.gmane.org>
2007-12-18 4:18 ` Jouni Malinen
[not found] ` <20071218041810.GB5698-mgr6C1c9aYeHXe+LvDLADg@public.gmane.org>
2007-12-18 12:47 ` Johannes Berg
2007-12-18 14:16 ` Johannes Berg
2007-12-16 9:28 ` Ron Rindjunsky
[not found] ` <c85cb4470712160128t7ef525f3md56d05f5990eb81-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2007-12-16 13:49 ` Johannes Berg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20071218042253.GC5698@jm.kir.nu \
--to=j@w1.fi \
--cc=flamingice@sourmilk.net \
--cc=johannes@sipsolutions.net \
--cc=linux-wireless@vger.kernel.org \
--cc=linville@tuxdriver.com \
--cc=netdev@vger.kernel.org \
--cc=tomasw@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).