From: David Miller <davem@davemloft.net>
To: herbert@gondor.apana.org.au
Cc: ilpo.jarvinen@helsinki.fi, netdev@vger.kernel.org
Subject: Re: TSO trimming question
Date: Wed, 19 Dec 2007 23:55:27 -0800 (PST) [thread overview]
Message-ID: <20071219.235527.231281143.davem@davemloft.net> (raw)
In-Reply-To: <E1J5C38-0004kh-00@gondolin.me.apana.org.au>
From: Herbert Xu <herbert@gondor.apana.org.au>
Date: Thu, 20 Dec 2007 11:26:18 +0800
> Ilpo J??rvinen <ilpo.jarvinen@helsinki.fi> wrote:
> >
> >> is the limitting factor? For latter IMHO this would be necessary:
> >>
> >> if (skb->len > limit)
> >> limit -= limit % mss_now;
>
> Good catch! But how about putting this logic into tcp_window_allows
> since then you can avoid the divide for the case when we're not
> bound by the receiver window.
Because the purpose of this calculation is different, as I
described in my other reply, I don't think this change is
correct, regardless of where it is placed :-)
next prev parent reply other threads:[~2007-12-20 7:55 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-12-19 21:46 TSO trimming question Ilpo Järvinen
2007-12-19 22:02 ` Ilpo Järvinen
2007-12-20 3:26 ` Herbert Xu
2007-12-20 7:55 ` David Miller [this message]
2007-12-20 7:54 ` David Miller
2007-12-20 11:40 ` Ilpo Järvinen
2007-12-20 11:56 ` David Miller
2007-12-20 16:02 ` John Heffner
2007-12-21 4:36 ` David Miller
2007-12-21 8:06 ` Bill Fink
2007-12-21 9:26 ` Ilpo Järvinen
2007-12-21 9:28 ` Ilpo Järvinen
2007-12-21 9:27 ` David Miller
2007-12-21 9:29 ` Herbert Xu
2007-12-21 9:36 ` David Miller
2007-12-21 10:58 ` Bill Fink
2007-12-21 18:54 ` Bill Fink
2007-12-21 18:58 ` Ilpo Järvinen
2007-12-21 19:37 ` Bill Fink
2007-12-20 12:00 ` David Miller
2007-12-20 12:35 ` Ilpo Järvinen
2007-12-20 14:00 ` Herbert Xu
2007-12-20 23:55 ` David Miller
2007-12-21 18:55 ` [PATCH] [TCP]: Force TSO splits to MSS boundaries Ilpo Järvinen
2007-12-21 20:01 ` Ilpo Järvinen
2007-12-25 5:35 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20071219.235527.231281143.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=herbert@gondor.apana.org.au \
--cc=ilpo.jarvinen@helsinki.fi \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).