From: David Miller <davem@davemloft.net>
To: timo.teras@iki.fi
Cc: kuznet@ms2.inr.ac.ru, netdev@vger.kernel.org
Subject: Re: [PATCH][IPV4] ip_gre: set mac_header correctly in receive path
Date: Thu, 20 Dec 2007 00:11:27 -0800 (PST) [thread overview]
Message-ID: <20071220.001127.23448802.davem@davemloft.net> (raw)
In-Reply-To: <47695EA1.10103@iki.fi>
From: Timo_Teräs <timo.teras@iki.fi>
Date: Wed, 19 Dec 2007 20:10:41 +0200
> From: Timo Teras <timo.teras@iki.fi>
>
> mac_header update in ipgre_recv() was incorrectly changed to
> skb_reset_mac_header() when it was introduced.
>
> Signed-off-by: Timo Teras <timo.teras@iki.fi>
Patch applied, thanks.
> ---
> This replaces my earlier patch titled "ip_gre: use skb->{mac,
> network}_header consistently". Apparently I hadn't done my homework how
> to use *_header correctly. And I should have done a bit more testing to
> figure out the previous patch does not work.
>
> But the main problem was the receive path in the first place, and this
> patch fixes it.
>
> The bug was introduced in commit 459a98ed881802dee55897441bc7f77af614368e.
> There might be other similar incorrect replaces.
That commit has two other identical bad conversions, I'll
fix them up.
prev parent reply other threads:[~2007-12-20 8:11 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-10-23 14:31 [PATCH RESEND] ip_gre: sendto/recvfrom NBMA address Timo Teräs
2007-10-23 14:33 ` Patrick McHardy
2007-10-23 15:08 ` Timo Teräs
2007-10-23 15:57 ` Timo Teräs
2007-10-23 16:10 ` Patrick McHardy
2007-10-23 19:03 ` Alexey Kuznetsov
2007-10-24 3:32 ` David Miller
2007-10-23 20:20 ` Alexey Kuznetsov
2007-10-24 5:54 ` Timo Teräs
2007-10-24 10:08 ` Alexey Kuznetsov
2007-12-18 13:59 ` [RFC][PATCH][IPV4] ip_gre: use skb->{mac,network}_header consistently Timo Teräs
2007-12-19 18:10 ` [PATCH][IPV4] ip_gre: set mac_header correctly in receive path Timo Teräs
2007-12-20 8:11 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20071220.001127.23448802.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=kuznet@ms2.inr.ac.ru \
--cc=netdev@vger.kernel.org \
--cc=timo.teras@iki.fi \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).