Re: [PATCH] drivers/net/niu: Support for Marvell PHY

[David Miller <davem@davemloft.net>]

From: Mirko Lindner <mlindner@marvell.com>
Date: Tue, 18 Dec 2007 17:03:58 +0100

> +static int xcvr_init_10g_mrvl88x2011(struct niu *np)
> +{
> +	int err;
> +
> +	/* Set LED functions */
> +	mrvl88x2011_led_blink_rate(np, 2);
> +	mrvl88x2011_act_led(np, 0);	/* led activity */
> +
> +	err = mdio_read(np, np->phy_addr, 3, 0x8300);
> +	if (err < 0) {
> +		return(err);
> +	}
> +
> +	err |= 0x0001;
> +
> +	err = mdio_write(np, np->phy_addr, 3, 0x8300, err);
> +	if (err < 0) {
> +		return(err);
> +	}
> +
> +	/* Enable PMD */
> +	err = mdio_write(np, np->phy_addr, 1, 0x0009, 0);
> +	
> +	return (err);
> +}
> +

This code doesn't handle putting the PHY into loopback more etc. like
the BCM8704 chip initialization does.

Please also fully document the registers using defines in the niu.h
header file as is already done for the BCM8704 registers.  Magic
constants are not allowed.

I'd like this Marvell PHY chip to be documented so that, just like the
BCM8704, someone can look at the driver and understand how the chip
works and thus make bug fixes and changes.