From: David Miller <davem@davemloft.net>
To: dlezcano@fr.ibm.com
Cc: netdev@vger.kernel.org, den@openvz.org, benjamin.thery@bull.net,
ebiederm@xmission.com
Subject: Re: [patch 1/2][NETNS] net: Modify the neighbour table code so it handles multiple network namespaces
Date: Thu, 20 Dec 2007 15:40:22 -0800 (PST) [thread overview]
Message-ID: <20071220.154022.13738739.davem@davemloft.net> (raw)
In-Reply-To: <20071219145830.605868037@ICON-9-164-138-215.megacenter.de.ibm.com>
From: Daniel Lezcano <dlezcano@fr.ibm.com>
Date: Wed, 19 Dec 2007 15:55:45 +0100
> -struct neigh_seq_state {
> +struct neigh_seq_state
> +{
Please don't make coding style change like this.
The accepted convention is:
struct NAME {
...
};
I know the other structs in that header file use the lousy:
struct NAME
{
};
format, but that doesn't make it right and we gain nothing
by taking a step backwards instead of fixing all the instances
in that header file over to the correct style.
next prev parent reply other threads:[~2007-12-20 23:40 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-12-19 14:55 [patch 0/2][NETNS] prepare the neigh subsys to handle network namespaces Daniel Lezcano
2007-12-19 14:55 ` [patch 1/2][NETNS] net: Modify the neighbour table code so it handles multiple " Daniel Lezcano
2007-12-20 23:40 ` David Miller [this message]
2007-12-19 14:55 ` [patch 2/2][NETNS] net: Add a helper function neigh_param_default_alloc Daniel Lezcano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20071220.154022.13738739.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=benjamin.thery@bull.net \
--cc=den@openvz.org \
--cc=dlezcano@fr.ibm.com \
--cc=ebiederm@xmission.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox