From mboxrd@z Thu Jan 1 00:00:00 1970 From: David Miller Subject: Re: [PATCH 2/4] [CORE]: datagram: basic memory accounting functions Date: Thu, 20 Dec 2007 20:31:05 -0800 (PST) Message-ID: <20071220.203105.209276041.davem@davemloft.net> References: <47673299.3010301@redhat.com> <20071220.034304.212231150.davem@davemloft.net> <476B3EAE.4070809@redhat.com> Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit Cc: herbert@gondor.apana.org.au, netdev@vger.kernel.org, tyasui@redhat.com, mhiramat@redhat.com, satoshi.oshima.fk@hitachi.com, billfink@mindspring.com, andi@firstfloor.org, johnpol@2ka.mipt.ru, shemminger@linux-foundation.org, yoshfuji@linux-ipv6.org, yumiko.sugita.yf@hitachi.com To: haoki@redhat.com Return-path: Received: from 74-93-104-97-Washington.hfc.comcastbusiness.net ([74.93.104.97]:50296 "EHLO sunset.davemloft.net" rhost-flags-OK-FAIL-OK-OK) by vger.kernel.org with ESMTP id S1751483AbXLUEbG (ORCPT ); Thu, 20 Dec 2007 23:31:06 -0500 In-Reply-To: <476B3EAE.4070809@redhat.com> Sender: netdev-owner@vger.kernel.org List-ID: From: Hideo AOKI Date: Thu, 20 Dec 2007 23:18:54 -0500 > > Also, the memory accounting is done at different parts in > > the socket code paths for stream vs. datagram. This is why > > everything is inconsistent, and, a mess. > > Could you tell me more detailed information? I think the core thing is that TCP and INET protocols call into the memory accounting internally, either inside their own code paths or with inet_*() helpers. This is versus what we really want is everything happening via generic sk_foo() helpers. If that's what's happening already, great, just consolidate the datagram vs. stream stuff and it should be good.