netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Jarek Poplawski <jarkao2@gmail.com>
To: Satoru SATOH <satoru.satoh@gmail.com>
Cc: netdev@vger.kernel.org
Subject: Re: [PATCH] [IPROUTE]: A workaround to make larger rto_min printed correctly
Date: Thu, 20 Dec 2007 10:12:30 +0100	[thread overview]
Message-ID: <20071220091230.GB1924@ff.dom.local> (raw)
In-Reply-To: <d72b7ace0712191931w37f02645u8d5eb5eef9c1fba4@mail.gmail.com>

On 20-12-2007 04:31, Satoru SATOH wrote:
> "ip route show" does not print correct value when larger rto_min is
> set (e.g. 3sec).
> 
> This problem is because of overflow in print_route() and
> the patch below is a workaround fix for that.
> 
...
> --- a/ip/iproute.c
> +++ b/ip/iproute.c
> @@ -510,16 +510,16 @@ int print_route(const struct sockaddr_nl *who,
> struct nlmsghdr *n, void *arg)
>                                 fprintf(fp, " %u",
> *(unsigned*)RTA_DATA(mxrta[i]));
>                         else {
>                                 unsigned val = *(unsigned*)RTA_DATA(mxrta[i]);
> +                               unsigned hz1 = hz / 1000;
...
> +                               if (val >= hz1)
> +                                       fprintf(fp, " %ums", val/hz1);
...

Probably I miss something or my iproute sources are too old, but:
does this work with hz < 1000?

Regards,
Jarek P.

  parent reply	other threads:[~2007-12-20  9:07 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-12-20  3:31 [PATCH] [IPROUTE]: A workaround to make larger rto_min printed correctly Satoru SATOH
2007-12-20  8:35 ` YOSHIFUJI Hideaki / 吉藤英明
2007-12-20  9:12 ` Jarek Poplawski [this message]
2007-12-20 16:21   ` Satoru SATOH
2007-12-20 20:24     ` Jarek Poplawski
2007-12-20 20:31       ` Jarek Poplawski
2007-12-21  2:24         ` Satoru SATOH
2007-12-21  8:34           ` Jarek Poplawski
2007-12-21  8:53           ` YOSHIFUJI Hideaki / 吉藤英明
2007-12-21 11:18             ` Bill Fink
2007-12-21 13:49             ` Satoru SATOH
2007-12-21 13:58               ` YOSHIFUJI Hideaki / 吉藤英明
2007-12-21 17:14                 ` Stephen Hemminger

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20071220091230.GB1924@ff.dom.local \
    --to=jarkao2@gmail.com \
    --cc=netdev@vger.kernel.org \
    --cc=satoru.satoh@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).