From: Ben Dooks <ben@fluff.org>
To: Daniel Mack <daniel@caiaq.de>
Cc: netdev@vger.kernel.org
Subject: Re: DM9000_IRQ_FLAGS
Date: Thu, 20 Dec 2007 09:45:25 +0000 [thread overview]
Message-ID: <20071220094524.GA9216@fluff.org.uk> (raw)
In-Reply-To: <20071211191823.GD15295@buzzloop.caiaq.de>
On Tue, Dec 11, 2007 at 08:18:23PM +0100, Daniel Mack wrote:
> Hi,
>
> on Toradex' Colibri, a PXA270 based board with a DM9000 ethernet
> controller, this driver won't work due to unsuitable DM9000_IRQ_FLAGS.
> If I understood the code behind request_irq() correctly, it's not
> recommended to register an IRQ without any of the IRQT_* flags set.
>
> Is there any concerns about applying the patch below?
Yes, that will possibly break all systems using level-triggered
interrupts.
Probably the best solution is to pass the data via the platform
information being fed to the device.
--
Ben (ben@fluff.org, http://www.fluff.org/)
'a smiley only costs 4 bytes'
prev parent reply other threads:[~2007-12-20 9:45 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-12-11 19:18 DM9000_IRQ_FLAGS Daniel Mack
2007-12-11 20:31 ` DM9000_IRQ_FLAGS Remy Bohmer
2007-12-12 13:41 ` DM9000_IRQ_FLAGS Daniel Mack
2007-12-12 14:46 ` DM9000_IRQ_FLAGS Remy Bohmer
2007-12-12 15:01 ` DM9000_IRQ_FLAGS Daniel Mack
2007-12-20 9:46 ` DM9000_IRQ_FLAGS Ben Dooks
2007-12-20 9:54 ` DM9000_IRQ_FLAGS Remy Bohmer
2008-01-15 11:42 ` DM9000_IRQ_FLAGS Daniel Mack
2007-12-20 9:45 ` Ben Dooks [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20071220094524.GA9216@fluff.org.uk \
--to=ben@fluff.org \
--cc=daniel@caiaq.de \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).