From: Steven Whitehouse <steve@chygwyn.com>
To: Pavel Emelyanov <xemul@openvz.org>
Cc: Linux Netdev List <netdev@vger.kernel.org>,
Patrick Caulfield <patrick@tykepenguin.com>,
linux-decnet-user@lists.sourceforge.net
Subject: Re: dn_neigh_table vs pneigh_lookup/pneigh_delete
Date: Thu, 20 Dec 2007 11:24:20 +0000 [thread overview]
Message-ID: <20071220112420.GA26048@fogou.chygwyn.com> (raw)
In-Reply-To: <47692696.1080905@openvz.org>
Hi,
On Wed, Dec 19, 2007 at 05:11:34PM +0300, Pavel Emelyanov wrote:
> Hi
>
> The pneigh_lookup/delete silently concerns, that the
> key_len of the table is more that 4 bytes. Look:
>
> u32 hash_val = *(u32 *)(pkey + key_len - 4);
>
> The hash_val for the proxy neighbor entry is four last bytes
> from the pkey.
>
> But the dn_neigh_tables' key_len is sizeof(__le16), that is 2,
> so setting (via netlink) the proxy neighbor entry for decnet
> will cause this entry to reside in arbitrary hash chain.
>
> Is this too bad for decnet?
>
> Thanks,
> Pavel
The pneigh code is never used in DECnet, we only use the "normal"
part of the neigh code where the hash function was changed so that
it can be defined for each protocol (and thus doesn't suffer from
this problem)
Steve.
prev parent reply other threads:[~2007-12-20 11:43 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-12-19 14:11 dn_neigh_table vs pneigh_lookup/pneigh_delete Pavel Emelyanov
2007-12-20 11:24 ` Steven Whitehouse [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20071220112420.GA26048@fogou.chygwyn.com \
--to=steve@chygwyn.com \
--cc=linux-decnet-user@lists.sourceforge.net \
--cc=netdev@vger.kernel.org \
--cc=patrick@tykepenguin.com \
--cc=xemul@openvz.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).