* [PATCH 1/2] e1000e: Use deferrable timer for watchdog
@ 2007-12-20 18:51 Auke Kok
2007-12-20 18:51 ` [PATCH 2/2] e1000: " Auke Kok
2007-12-20 21:27 ` [PATCH 1/2] e1000e: " Kok, Auke
0 siblings, 2 replies; 3+ messages in thread
From: Auke Kok @ 2007-12-20 18:51 UTC (permalink / raw)
To: jeff; +Cc: netdev, parag.warudkar
From: Parag Warudkar <parag.warudkar@gmail.com>
Reduce wakeups from idle per second.
Signed-off-by: Parag Warudkar <parag.warudkar@gmail.com>
Signed-off-by: Auke Kok <auke-jan.h.kok@intel.com>
---
drivers/net/e1000e/netdev.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/drivers/net/e1000e/netdev.c b/drivers/net/e1000e/netdev.c
index 2422d16..59960d2 100644
--- a/drivers/net/e1000e/netdev.c
+++ b/drivers/net/e1000e/netdev.c
@@ -3931,7 +3931,7 @@ static int __devinit e1000_probe(struct pci_dev *pdev,
goto err_eeprom;
}
- init_timer(&adapter->watchdog_timer);
+ init_timer_deferrable(&adapter->watchdog_timer);
adapter->watchdog_timer.function = &e1000_watchdog;
adapter->watchdog_timer.data = (unsigned long) adapter;
^ permalink raw reply related [flat|nested] 3+ messages in thread
* [PATCH 2/2] e1000: Use deferrable timer for watchdog
2007-12-20 18:51 [PATCH 1/2] e1000e: Use deferrable timer for watchdog Auke Kok
@ 2007-12-20 18:51 ` Auke Kok
2007-12-20 21:27 ` [PATCH 1/2] e1000e: " Kok, Auke
1 sibling, 0 replies; 3+ messages in thread
From: Auke Kok @ 2007-12-20 18:51 UTC (permalink / raw)
To: jeff; +Cc: netdev, parag.warudkar
From: Parag Warudkar <parag.warudkar@gmail.com>
Reduces wakeups from idle per second.
Signed-off-by: Parag Warudkar <parag.warudkar@gmail.com>
Signed-off-by: Auke Kok <auke-jan.h.kok@intel.com>
---
drivers/net/e1000/e1000_main.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/drivers/net/e1000/e1000_main.c b/drivers/net/e1000/e1000_main.c
index 599153d..6af86fa 100644
--- a/drivers/net/e1000/e1000_main.c
+++ b/drivers/net/e1000/e1000_main.c
@@ -1066,7 +1066,7 @@ e1000_probe(struct pci_dev *pdev,
adapter->tx_fifo_stall_timer.function = &e1000_82547_tx_fifo_stall;
adapter->tx_fifo_stall_timer.data = (unsigned long) adapter;
- init_timer(&adapter->watchdog_timer);
+ init_timer_deferrable(&adapter->watchdog_timer);
adapter->watchdog_timer.function = &e1000_watchdog;
adapter->watchdog_timer.data = (unsigned long) adapter;
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH 1/2] e1000e: Use deferrable timer for watchdog
2007-12-20 18:51 [PATCH 1/2] e1000e: Use deferrable timer for watchdog Auke Kok
2007-12-20 18:51 ` [PATCH 2/2] e1000: " Auke Kok
@ 2007-12-20 21:27 ` Kok, Auke
1 sibling, 0 replies; 3+ messages in thread
From: Kok, Auke @ 2007-12-20 21:27 UTC (permalink / raw)
To: jeff; +Cc: netdev, parag.warudkar
Auke Kok wrote:
> From: Parag Warudkar <parag.warudkar@gmail.com>
>
> Reduce wakeups from idle per second.
>
> Signed-off-by: Parag Warudkar <parag.warudkar@gmail.com>
> Signed-off-by: Auke Kok <auke-jan.h.kok@intel.com>
> ---
Jeff,
given the discussion with Stephen I'd like to skip merging this patch and the
e1000 one for now. The unforeseen implications of this are just not controlled
enough and we need to guarantee some limit of deferral first.
Auke
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2007-12-20 21:32 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2007-12-20 18:51 [PATCH 1/2] e1000e: Use deferrable timer for watchdog Auke Kok
2007-12-20 18:51 ` [PATCH 2/2] e1000: " Auke Kok
2007-12-20 21:27 ` [PATCH 1/2] e1000e: " Kok, Auke
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).