From mboxrd@z Thu Jan 1 00:00:00 1970 From: YOSHIFUJI Hideaki / =?iso-2022-jp?B?GyRCNUhGIzFRTEAbKEI=?= Subject: Re: [PATCH net-2.6][NEIGH] Updating affected neighbours when about MAC address change Date: Sun, 23 Dec 2007 22:13:55 +0900 (JST) Message-ID: <20071223.221355.40687949.yoshfuji@linux-ipv6.org> References: <31436f4a0712230424n1cfaeb27o463e62093af41090@mail.gmail.com> <20071223.213841.108421688.yoshfuji@linux-ipv6.org> <31436f4a0712230504x7b0b4f38i8f69a7a825bcc14b@mail.gmail.com> Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit Cc: davem@davemloft.net, netdev@vger.kernel.org, yoshfuji@linux-ipv6.org To: dshwatrz@gmail.com Return-path: Received: from yue.linux-ipv6.org ([203.178.140.15]:44312 "EHLO yue.st-paulia.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751499AbXLWNNR (ORCPT ); Sun, 23 Dec 2007 08:13:17 -0500 In-Reply-To: <31436f4a0712230504x7b0b4f38i8f69a7a825bcc14b@mail.gmail.com> Sender: netdev-owner@vger.kernel.org List-ID: In article <31436f4a0712230504x7b0b4f38i8f69a7a825bcc14b@mail.gmail.com> (at Sun, 23 Dec 2007 15:04:37 +0200), "David Shwatrz" says: > Hello, > > > >You should iterate all of ifa_list (for IPv4) / addr_list (for IPv6). > > For IPv6, we also have anycast (maintained by ac_list) as well. > > I am not sure that we need to iterate all of ifa_list in IPv4. > The reason is that we end with arp_send, and it initiates a broadcast. > So all neighbours will receive it and update their arp tables > accordingly. > The dest hw in the arp_send is NULL according to this patch ; this means that > we will assign dev->broadcast to dest_hw in apr_create(). > > It seems to me there's no reason to send more than one broadcast. Urgh? what is happend if you have multiple IPv4 addresses on the device? > In IPv6, I need to check, since it is multicast. Please read RFC2461 Section 7.2.6. In short we should send a few unsolicited NA, but I think you can start from sending once per an address. --yoshfuji