From: David Miller <davem@davemloft.net>
To: mchan@broadcom.com
Cc: joe@perches.com, netdev@vger.kernel.org, anilgv@broadcom.com,
michaelc@cs.wisc.edu, david.somayajulu@qlogic.com
Subject: Re: [ETH]: Combine format_addr() with print_mac().
Date: Mon, 24 Dec 2007 21:28:37 -0800 (PST) [thread overview]
Message-ID: <20071224.212837.265942369.davem@davemloft.net> (raw)
In-Reply-To: <1198455635.5491.4.camel@dell>
From: "Michael Chan" <mchan@broadcom.com>
Date: Sun, 23 Dec 2007 16:20:35 -0800
> Here's the revised patch:
>
> [ETH]: Combine format_addr() with print_mac().
>
> print_mac() used many most net drivers and format_addr() used by
> net-sysfs.c are very similar and they can be intergrated.
>
> format_addr() is also identically redefined in the qla4xxx iscsi
> driver.
>
> Export a new function sysfs_format_mac() to be used by net-sysfs,
> qla4xxx and others in the future. Both print_mac() and
> sysfs_format_mac() call _format_mac_addr() to do the formatting.
>
> Changed print_mac() to use unsigned char * to be consistent with
> net_device struct's dev_addr. Added buffer length overrun checking
> as suggested by Joe Perches.
>
> Signed-off-by: Michael Chan <mchan@broadcom.com>
Applied to net-2.6.25, thanks Michael.
prev parent reply other threads:[~2007-12-25 5:28 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-12-21 22:05 [ETH]: Combine format_addr() with print_mac() Michael Chan
2007-12-21 22:36 ` Joe Perches
2007-12-22 3:58 ` Michael Chan
2007-12-22 7:02 ` Joe Perches
2007-12-24 0:20 ` Michael Chan
2007-12-25 5:28 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20071224.212837.265942369.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=anilgv@broadcom.com \
--cc=david.somayajulu@qlogic.com \
--cc=joe@perches.com \
--cc=mchan@broadcom.com \
--cc=michaelc@cs.wisc.edu \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).