From: David Miller <davem@davemloft.net>
To: tabe@miraclelinux.com
Cc: joe@perches.com, netdev@vger.kernel.org, maxk@qualcomm.com
Subject: Re: [PATCH] TUNTAP: Fix wrong debug message
Date: Mon, 24 Dec 2007 21:30:58 -0800 (PST) [thread overview]
Message-ID: <20071224.213058.167442659.davem@davemloft.net> (raw)
In-Reply-To: <20071225.122756.-713540829.tabe@miraclelinux.com>
From: Toyo Abe <tabe@miraclelinux.com>
Date: Tue, 25 Dec 2007 12:27:56 +0900 (JST)
> --- Original Messsage ---
> From: Joe Perches <joe@perches.com>
> Subject: Re: [PATCH] TUNTAP: Fix wrong debug message
> Date: Mon, 24 Dec 2007 18:48:48 -0800
> Message-ID: <1198550928.19504.1.camel@localhost>
>
> > More readable to reverse the strings
> >
> > tun->dev->name, arg ? "enabled" : "disabled");
> >
>
> Hello Joe,
> Thanks for your advice.
>
> This is the more readable version.
Applied, thanks Toyo.
Joe, please don't provide patch feedback in private emails as it
appears you did here. When you do this, it cheapens the value
of the feedback because other people reading the list cannot
benefit nor comment on it.
You've done this to me in the past too, and I told you back then
to please stop doing it.
Thanks.
prev parent reply other threads:[~2007-12-25 5:30 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-12-25 1:53 [PATCH] TUNTAP: Fix wrong debug message Toyo Abe
[not found] ` <1198550928.19504.1.camel@localhost>
2007-12-25 3:27 ` Toyo Abe
2007-12-25 5:30 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20071224.213058.167442659.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=joe@perches.com \
--cc=maxk@qualcomm.com \
--cc=netdev@vger.kernel.org \
--cc=tabe@miraclelinux.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).