netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Toyo Abe <tabe@miraclelinux.com>
To: joe@perches.com
Cc: netdev@vger.kernel.org, maxk@qualcomm.com
Subject: Re: [PATCH] TUNTAP: Fix wrong debug message
Date: Tue, 25 Dec 2007 12:27:56 +0900 (JST)	[thread overview]
Message-ID: <20071225.122756.-713540829.tabe@miraclelinux.com> (raw)
In-Reply-To: <1198550928.19504.1.camel@localhost>

[-- Attachment #1: Type: Text/Plain, Size: 396 bytes --]

--- Original Messsage ---
From: Joe Perches <joe@perches.com>
Subject: Re: [PATCH] TUNTAP: Fix wrong debug message
Date: Mon, 24 Dec 2007 18:48:48 -0800
Message-ID: <1198550928.19504.1.camel@localhost>

> More readable to reverse the strings
> 
> 		    tun->dev->name, arg ? "enabled" : "disabled");
> 

Hello Joe,
Thanks for your advice.

This is the more readable version.

Best Regards,
-toyo

[-- Attachment #2: TUNTAP-Fix-wrong-debug-message.patch --]
[-- Type: Text/Plain, Size: 673 bytes --]

This is a trivial fix of debug message.
When a persist flag is set, the message should say "enabled".

Signed-off-by: Toyo Abe <tabe@miraclelinux.com>
---
 drivers/net/tun.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/drivers/net/tun.c b/drivers/net/tun.c
index 1f76446..f8b8c71 100644
--- a/drivers/net/tun.c
+++ b/drivers/net/tun.c
@@ -610,7 +610,7 @@ static int tun_chr_ioctl(struct inode *inode, struct file *file,
 			tun->flags &= ~TUN_PERSIST;
 
 		DBG(KERN_INFO "%s: persist %s\n",
-		    tun->dev->name, arg ? "disabled" : "enabled");
+		    tun->dev->name, arg ? "enabled" : "disabled");
 		break;
 
 	case TUNSETOWNER:
-- 
1.5.3.6


  parent reply	other threads:[~2007-12-25  3:36 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-12-25  1:53 [PATCH] TUNTAP: Fix wrong debug message Toyo Abe
     [not found] ` <1198550928.19504.1.camel@localhost>
2007-12-25  3:27   ` Toyo Abe [this message]
2007-12-25  5:30     ` David Miller

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20071225.122756.-713540829.tabe@miraclelinux.com \
    --to=tabe@miraclelinux.com \
    --cc=joe@perches.com \
    --cc=maxk@qualcomm.com \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).