[PATCH] TUNTAP: Fix wrong debug message

[PATCH] TUNTAP: Fix wrong debug message

[Toyo Abe]

This is a trivial fix of debug message.
When a persist flag is set, the message should say "enabled".

Signed-off-by: Toyo Abe <tabe@miraclelinux.com>
---
 drivers/net/tun.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/drivers/net/tun.c b/drivers/net/tun.c
index 1f76446..e5a3f5d 100644
--- a/drivers/net/tun.c
+++ b/drivers/net/tun.c
@@ -610,7 +610,7 @@ static int tun_chr_ioctl(struct inode *inode, struct file *file,
 			tun->flags &= ~TUN_PERSIST;
 
 		DBG(KERN_INFO "%s: persist %s\n",
-		    tun->dev->name, arg ? "disabled" : "enabled");
+		    tun->dev->name, (!arg) ? "disabled" : "enabled");
 		break;
 
 	case TUNSETOWNER:
-- 
1.5.3.6

Re: [PATCH] TUNTAP: Fix wrong debug message

[Toyo Abe]

[-- Attachment #1: Type: Text/Plain, Size: 396 bytes --]

--- Original Messsage ---
From: Joe Perches <joe@perches.com>
Subject: Re: [PATCH] TUNTAP: Fix wrong debug message
Date: Mon, 24 Dec 2007 18:48:48 -0800
Message-ID: <1198550928.19504.1.camel@localhost>

> More readable to reverse the strings
> 
> 		    tun->dev->name, arg ? "enabled" : "disabled");
> 

Hello Joe,
Thanks for your advice.

This is the more readable version.

Best Regards,
-toyo

[-- Attachment #2: TUNTAP-Fix-wrong-debug-message.patch --]
[-- Type: Text/Plain, Size: 673 bytes --]

This is a trivial fix of debug message.
When a persist flag is set, the message should say "enabled".

Signed-off-by: Toyo Abe <tabe@miraclelinux.com>
---
 drivers/net/tun.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/drivers/net/tun.c b/drivers/net/tun.c
index 1f76446..f8b8c71 100644
--- a/drivers/net/tun.c
+++ b/drivers/net/tun.c
@@ -610,7 +610,7 @@ static int tun_chr_ioctl(struct inode *inode, struct file *file,
 			tun->flags &= ~TUN_PERSIST;
 
 		DBG(KERN_INFO "%s: persist %s\n",
-		    tun->dev->name, arg ? "disabled" : "enabled");
+		    tun->dev->name, arg ? "enabled" : "disabled");
 		break;
 
 	case TUNSETOWNER:
-- 
1.5.3.6

Re: [PATCH] TUNTAP: Fix wrong debug message

[David Miller]

From: Toyo Abe <tabe@miraclelinux.com>
Date: Tue, 25 Dec 2007 12:27:56 +0900 (JST)

> --- Original Messsage ---
> From: Joe Perches <joe@perches.com>
> Subject: Re: [PATCH] TUNTAP: Fix wrong debug message
> Date: Mon, 24 Dec 2007 18:48:48 -0800
> Message-ID: <1198550928.19504.1.camel@localhost>
> 
> > More readable to reverse the strings
> > 
> > 		    tun->dev->name, arg ? "enabled" : "disabled");
> > 
> 
> Hello Joe,
> Thanks for your advice.
> 
> This is the more readable version.

Applied, thanks Toyo.

Joe, please don't provide patch feedback in private emails as it
appears you did here.  When you do this, it cheapens the value
of the feedback because other people reading the list cannot
benefit nor comment on it.

You've done this to me in the past too, and I told you back then
to please stop doing it.

Thanks.