From: Stephen Hemminger <shemminger@linux-foundation.org>
To: David Miller <davem@davemloft.net>
Cc: vgusev@openvz.org, netdev@vger.kernel.org
Subject: Re: [PATCH] net: santize headers for iproute2
Date: Tue, 25 Dec 2007 12:43:23 -0800 [thread overview]
Message-ID: <20071225124323.70e0c772@deepthought> (raw)
In-Reply-To: <20071224.220527.254578945.davem@davemloft.net>
> net/tcp_states.h is not movable to include/linux/ and thus to
> userspace, it defines things that are present already in existing
> userland header files. If you look, <netinet/tcp.h> defines these
> state values, as an enumeration. If you need the TCPF_* flag bit
> versions, sorry... you'll need to find some other way to get those
> into userspace.
The problem is that iproute ss.c needs linux/tcp.h to get the tcp_info
structure definition but linux/tcp.h has incompatible definitions with netinet/tcp.h.
I propose that the enum be moved from net/tcp_states.h to linux/tcp.h.
--
Stephen Hemminger <stephen.hemminger@vyatta.com>
next prev parent reply other threads:[~2007-12-25 20:44 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-12-21 17:43 [PATCH] net: santize headers for iproute2 Stephen Hemminger
2007-12-25 6:05 ` David Miller
2007-12-25 20:43 ` Stephen Hemminger [this message]
2007-12-25 23:02 ` David Miller
2007-12-26 1:13 ` Stephen Hemminger
2007-12-30 3:22 ` David Miller
2007-12-31 18:55 ` Stephen Hemminger
2007-12-25 20:46 ` [PATCH] veth: move veth.h to include/linux Stephen Hemminger
2007-12-25 22:23 ` Sam Ravnborg
2007-12-26 1:14 ` Stephen Hemminger
2007-12-26 1:19 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20071225124323.70e0c772@deepthought \
--to=shemminger@linux-foundation.org \
--cc=davem@davemloft.net \
--cc=netdev@vger.kernel.org \
--cc=vgusev@openvz.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).