From: Sam Ravnborg <sam@ravnborg.org>
To: Stephen Hemminger <stephen.hemminger@vyatta.com>
Cc: David Miller <davem@davemloft.net>,
vgusev@openvz.org, netdev@vger.kernel.org
Subject: Re: [PATCH] veth: move veth.h to include/linux
Date: Tue, 25 Dec 2007 23:23:35 +0100 [thread overview]
Message-ID: <20071225222335.GA5927@uranus.ravnborg.org> (raw)
In-Reply-To: <20071225124656.723c2db6@deepthought>
On Tue, Dec 25, 2007 at 12:46:56PM -0800, Stephen Hemminger wrote:
> Move veth.h from net/ to linux/ since it is a user api, and
> add it to user header processing Kbuild.
>
> Signed-off-by: Stephen Hemminger <shemminger@linux-foundation.org>
>
> --- a/drivers/net/veth.c 2007-12-25 12:30:56.000000000 -0800
> +++ b/drivers/net/veth.c 2007-12-25 12:31:38.000000000 -0800
> @@ -15,7 +15,7 @@
>
> #include <net/dst.h>
> #include <net/xfrm.h>
> -#include <net/veth.h>
> +#include <linux/veth.h>
>
> #define DRV_NAME "veth"
> #define DRV_VERSION "1.0"
> --- /dev/null 1970-01-01 00:00:00.000000000 +0000
> +++ b/include/linux/veth.h 2007-10-16 16:48:20.000000000 -0700
> @@ -0,0 +1,12 @@
> +#ifndef __NET_VETH_H_
> +#define __NET_VETH_H_
> +
> +enum {
> + VETH_INFO_UNSPEC,
> + VETH_INFO_PEER,
> +
> + __VETH_INFO_MAX
> +#define VETH_INFO_MAX (__VETH_INFO_MAX - 1)
> +};
> +
> +#endif
> --- a/include/net/veth.h 2007-12-25 12:33:49.000000000 -0800
> +++ /dev/null 1970-01-01 00:00:00.000000000 +0000
> @@ -1,12 +0,0 @@
> -#ifndef __NET_VETH_H_
> -#define __NET_VETH_H_
> -
> -enum {
> - VETH_INFO_UNSPEC,
> - VETH_INFO_PEER,
> -
> - __VETH_INFO_MAX
> -#define VETH_INFO_MAX (__VETH_INFO_MAX - 1)
> -};
> -
> -#endif
> --- a/include/linux/Kbuild 2007-12-25 12:44:59.000000000 -0800
> +++ b/include/linux/Kbuild 2007-12-25 12:45:31.000000000 -0800
> @@ -342,6 +342,7 @@ unifdef-y += unistd.h
> unifdef-y += usbdevice_fs.h
> unifdef-y += user.h
> unifdef-y += utsname.h
> +unifdef-y += veth.h
> unifdef-y += videodev2.h
> unifdef-y += videodev.h
> unifdef-y += virtio_config.h
Someone will argue that you should use header-y +=
because the file has no conditionals removed by unifdef.
My personal opinion is that we should kill header-y and
I had patches to greatly improve all this but they got
lost by accident and I have not yet redone them.
Sam
> --
> To unsubscribe from this list: send the line "unsubscribe netdev" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2007-12-25 22:21 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-12-21 17:43 [PATCH] net: santize headers for iproute2 Stephen Hemminger
2007-12-25 6:05 ` David Miller
2007-12-25 20:43 ` Stephen Hemminger
2007-12-25 23:02 ` David Miller
2007-12-26 1:13 ` Stephen Hemminger
2007-12-30 3:22 ` David Miller
2007-12-31 18:55 ` Stephen Hemminger
2007-12-25 20:46 ` [PATCH] veth: move veth.h to include/linux Stephen Hemminger
2007-12-25 22:23 ` Sam Ravnborg [this message]
2007-12-26 1:14 ` Stephen Hemminger
2007-12-26 1:19 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20071225222335.GA5927@uranus.ravnborg.org \
--to=sam@ravnborg.org \
--cc=davem@davemloft.net \
--cc=netdev@vger.kernel.org \
--cc=stephen.hemminger@vyatta.com \
--cc=vgusev@openvz.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).