From: Al Viro <viro@ZenIV.linux.org.uk>
To: Francois Romieu <romieu@fr.zoreil.com>
Cc: Al Viro <viro@ftp.linux.org.uk>,
netdev@vger.kernel.org, jgarzik@pobox.com
Subject: Re: [PATCH] via-velocity big-endian support
Date: Tue, 25 Dec 2007 22:56:06 +0000 [thread overview]
Message-ID: <20071225225606.GC27894@ZenIV.linux.org.uk> (raw)
In-Reply-To: <20071225224333.GA21585@electric-eye.fr.zoreil.com>
On Tue, Dec 25, 2007 at 11:43:33PM +0100, Francois Romieu wrote:
> > +#define DESC_OWNER cpu_to_le16(0x8000)
> > +
>
> DESC_OWNER does not seem to be used.
*nod*
That should be removed.
> [...]
> > +enum {
> > + RX_INTEN = __constant_cpu_to_le16(0x8000)
> > +};
>
> Can we avoid using cpu_to_leXY here for consistency sake within the driver
> (and among different drivers as well) ?
???
What is the problem with having such constants? If you mean "could we
use cpu_to_le16() instead of __constant_cpu_to_le16()", the answer's
no - that's one of the very few places where __constant_.... form is
needed (other are case <...>: and initializers for non-auto variables).
next prev parent reply other threads:[~2007-12-25 22:56 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-12-24 5:06 [PATCH] via-velocity big-endian support Al Viro
2007-12-25 22:43 ` Francois Romieu
2007-12-25 22:56 ` Al Viro [this message]
2007-12-25 23:21 ` Francois Romieu
2007-12-28 18:40 ` Al Viro
2008-01-07 23:18 ` Francois Romieu
2008-01-08 5:34 ` linux
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20071225225606.GC27894@ZenIV.linux.org.uk \
--to=viro@zeniv.linux.org.uk \
--cc=jgarzik@pobox.com \
--cc=netdev@vger.kernel.org \
--cc=romieu@fr.zoreil.com \
--cc=viro@ftp.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).